fix(run): align schemas url versions (#5085)

* fix(run): align schemas url versions * fix(run): align SchemaURL versions --------- Co-authored-by: Jennifer Davis <[email protected]>
GoogleCloudPlatform · Jan 15, 2025 · e1deb3a · e1deb3a
1 parent 62149a6
commit e1deb3a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/run/custom-metrics/main.go b/run/custom-metrics/main.go
@@ -48,7 +48,7 @@ func main() {
 
 func handler(w http.ResponseWriter, r *http.Request) {
 	counter.Add(context.Background(), 100)
-	fmt.Fprintln(w, "Incremented sidecar_sample_counter metric!")
+	fmt.Fprintln(w, "Incremented sidecar_sample_counter_total metric!")
 }
 
 func setupCounter(ctx context.Context) func(context.Context) error {
@@ -59,7 +59,7 @@ func setupCounter(ctx context.Context) func(context.Context) error {
 	r, err := resource.Merge(
 		resource.Default(),
 		resource.NewWithAttributes(
-			semconv.SchemaURL,
+			resource.Default().SchemaURL(),
 			semconv.ServiceName(serviceName),
 		),
 	)

diff --git a/run/custom-metrics/main_test.go b/run/custom-metrics/main_test.go
@@ -40,7 +40,7 @@ func TestHandler(t *testing.T) {
 	}{
 		{
 			name:     "basic test",
-			expected: "Incremented sidecar_sample_counter metric!\n",
+			expected: "Incremented sidecar_sample_counter_total metric!\n",
 		},
 	}
-Original file line number
+Diff line change
@@ Expand Up / @@ -40,7 +40,7 @@ func TestHandler(t *testing.T) { @@
     	}{
     		{
     			name:     "basic test",
-    			expected: "Incremented sidecar_sample_counter metric!\n",
+    			expected: "Incremented sidecar_sample_counter_total metric!\n",
     		},
     	}
@@ Expand Down @@