Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve visibility of Skipped tests in kokoro CI #3568

Open
muncus opened this issue Nov 14, 2023 · 0 comments
Open

Improve visibility of Skipped tests in kokoro CI #3568

muncus opened this issue Nov 14, 2023 · 0 comments
Assignees
@muncus
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. stale: old Pull request is old and needs attention. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. type: process A process-related concern. May include testing, release, or the like.

Comments

@muncus
Copy link
Collaborator

muncus commented Nov 14, 2023

On several occasions, tests that kokoro CI has skipped (due to, for example, requiring a newer version of Go than we currently support), results in CI builds that appear to succeed, when in fact, no tests were run.

This is confusing, and leads to merging PRs that will later become failing tests (when we upgrade our supported versions).

As an example this incorrect test will never pass, because it hard-codes a project ID. In the PR status checks, the test was not run.
@muncus muncus added priority: p3 Desirable enhancement or fix. May not be included in next release. triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 14, 2023
@muncus muncus self-assigned this Nov 14, 2023
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 14, 2023
@muncus muncus added type: process A process-related concern. May include testing, release, or the like. and removed triage me I really want to be triaged. samples Issues that are directly related to samples. labels Nov 14, 2023
@muncus muncus mentioned this issue Nov 15, 2023
Closed
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 15, 2023
@subfuzion subfuzion added the stale: old Pull request is old and needs attention. label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muncus muncus

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. stale: old Pull request is old and needs attention. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@subfuzion @muncus and others