Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discoveryengine tests hard-code project ID #3569

Closed
muncus opened this issue Nov 15, 2023 · 0 comments · Fixed by #4373
Closed

discoveryengine tests hard-code project ID #3569

muncus opened this issue Nov 15, 2023 · 0 comments · Fixed by #4373
Assignees
@telpirion
Labels
api: discoveryengine Issues related to the Discovery Engine API API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. stale: old Pull request is old and needs attention. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@muncus
Copy link
Collaborator

muncus commented Nov 15, 2023

The discoveryengine tests at

golang-samples/discoveryengine/search_test.go

Line 4 in f2e5277

// you may not use this file except in compliance with the License.

will never pass, as they hardcode a project id, and they appear to require a search engine resource that does not exist in our test projects. The tests should use testutil.SystemTest() to retrieve a project ID, and dynamically create the other necessary resources, if possible.

These tests appeared to pass at merge time because of #3568. oops!
@muncus muncus added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. triage me I really want to be triaged. api: discoveryengine Issues related to the Discovery Engine API API. labels Nov 15, 2023
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 15, 2023
@muncus muncus mentioned this issue Nov 15, 2023
Merged
@subfuzion subfuzion added the stale: old Pull request is old and needs attention. label Jul 31, 2024
@telpirion telpirion self-assigned this Sep 10, 2024
@telpirion telpirion mentioned this issue Sep 10, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@telpirion telpirion

Labels
api: discoveryengine Issues related to the Discovery Engine API API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. stale: old Pull request is old and needs attention. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove discoveryengine samples telpirion/golang-samples
4 participants
@subfuzion @muncus @telpirion and others