Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove discoveryengine samples #4373

Merged
merged 8 commits into from
Sep 11, 2024

Conversation

telpirion
Copy link
Collaborator

@telpirion telpirion commented Sep 10, 2024

Description

Fixes #3569

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Per this documentation, discovery engine has been deprecated in favor of Vertex Agent Builder.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 10, 2024
@telpirion telpirion marked this pull request as ready for review September 11, 2024 16:08
@telpirion telpirion requested review from a team as code owners September 11, 2024 16:08
Copy link

snippet-bot bot commented Sep 11, 2024

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning these samples up!

@telpirion telpirion merged commit 2483fc0 into GoogleCloudPlatform:main Sep 11, 2024
9 checks passed
@holtskinner
Copy link
Contributor

@telpirion Hi, these samples are current. They are in use for Vertex AI Agent Builder. Can they please be added back in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

discoveryengine tests hard-code project ID
3 participants