Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AR migration for kokoro, pt 1 #4453

Merged
merged 5 commits into from
Oct 30, 2024
Merged

feat: AR migration for kokoro, pt 1 #4453

merged 5 commits into from
Oct 30, 2024

Conversation

muncus
Copy link
Collaborator

@muncus muncus commented Oct 28, 2024

Description

Update kokoro image builds, and the latest-version kokoro build to use Artifact
Registry.

The container images exist for go 1.21 and 1.23 already.

Part of #4228

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 28, 2024
@iennae
Copy link
Contributor

iennae commented Oct 29, 2024

approved, but kokoro CI is failing with minimal output so this might not be an ok change.

@muncus
Copy link
Collaborator Author

muncus commented Oct 29, 2024

Looks like something else is needed to allow kokoro to pull images from the new location.

[11:16:59 PDT] ERROR: This is a presubmit run, but Kokoro always reads job configs from head. If your un-submitted change modifies allowed_env_vars, it is ignored.
[11:16:59 PDT][ERROR] Build failed due to an error
com.google.devtools.kokoro.controller.UserException: Found un-allowed variables:

TRAMPOLINE_IMAGE="us-docker.pkg.dev/golang-samples-tests/kokoro-images/go123" (No matching value in allowed env vars)

@muncus muncus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2024
@muncus muncus removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2024
@muncus muncus marked this pull request as ready for review October 29, 2024 21:49
@muncus muncus requested review from a team as code owners October 29, 2024 21:49
@muncus
Copy link
Collaborator Author

muncus commented Oct 30, 2024

the failing tests on this run are caused by quota and "already exists" errors, neither of which appear to be caused by this change.

@muncus muncus merged commit 9f09af3 into main Oct 30, 2024
10 of 11 checks passed
@muncus muncus deleted the ar-images1 branch October 30, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants