Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gae): migrate region step 1 #5089

Conversation

OremGLG
Copy link
Contributor

@OremGLG OremGLG commented Jan 15, 2025

Description

Migrate region "creating_namespaces_on_a_per_user_basis" to "gae_creating_namespaces_on_a_per_user_basis"

Fixes b/389090879

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly understand the changes:

This pull request, submitted by OremGLG, aims to migrate the region identifier for a specific App Engine multitenancy sample. The intent is to fix issue b/389090879.

Specifically, the changes involve updating the docs/appengine/multitenancy/namespace_user.go file. The changes are as follows:

  • Line 17: The old region identifier creating_namespaces_on_a_per_user_basis is replaced with the new identifier gae_creating_namespaces_on_a_per_user_basis.
  • Line 36: A corresponding change is made to the closing comment, mirroring the update in line 17.

The changes are straightforward and appear to correctly reflect the intended migration. I'll be checking for any unintended side effects during my full review.


A little poem for your coding pleasure:

A region's name changed,
A simple fix, yet so grand,
Code flows anew.

Thanks!
Gemini

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 15, 2025
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request migrates the region tag "creating_namespaces_on_a_per_user_basis" to "gae_creating_namespaces_on_a_per_user_basis" in namespace_user.go. The change is small and seems correct. The checklist is mostly irrelevant to this change and should be simplified.

@OremGLG OremGLG marked this pull request as ready for review January 16, 2025 16:34
@OremGLG OremGLG requested review from a team as code owners January 16, 2025 16:34
Copy link

snippet-bot bot commented Jan 16, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@telpirion telpirion self-assigned this Jan 16, 2025
@telpirion telpirion merged commit 7778c64 into GoogleCloudPlatform:main Jan 16, 2025
9 checks passed
@OremGLG OremGLG deleted the garciadiaz-migrate-region-step-1-389090879 branch January 16, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants