Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gae): delete old region tag #5092

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OremGLG
Copy link
Contributor

@OremGLG OremGLG commented Jan 16, 2025

Description

Delete old region tag

Fixes b/389090879

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly understand the changes:

This pull request, submitted by OremGLG, aims to fix issue b/389090879 by deleting an outdated region tag. The changes are focused on the file docs/appengine/multitenancy/namespace_user.go.

Here's a breakdown of the changes:

  • File: docs/appengine/multitenancy/namespace_user.go
    • Change 1 (lines 17-18): Removed the old region tag // [START creating_namespaces_on_a_per_user_basis].
    • Change 2 (lines 34-35): Removed the corresponding closing tag // [END creating_namespaces_on_a_per_user_basis].

The author has indicated that code formatting and vetting have passed. Testing is still pending.

I'll provide a more detailed review soon.


A little haiku to lighten the mood:

Old tags now removed,
Code cleaner, bright, and new,
Reviewing's a breeze.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 16, 2025
Copy link

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

@OremGLG OremGLG marked this pull request as ready for review January 16, 2025 17:55
@OremGLG OremGLG requested review from a team as code owners January 16, 2025 17:55
Copy link

snippet-bot bot commented Jan 16, 2025

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant