Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EphemeralWriteOnly: add disk_encryption_key.0.rawKeyWo to compute_region_disk #12789

Conversation

BBBmau
Copy link
Collaborator

@BBBmau BBBmau commented Jan 17, 2025

Complete the self-review checklist to help speed up the review process: https://googlecloudplatform.github.io/magic-modules/contribute/review-pr/

If your PR is still work in progress, please create it in draft mode.

Put a description of what this PR is for here, along with any references to issues that this resolves or contributes to.
For example: Fixes https://github.com/hashicorp/terraform-provider-google/issues/ISSUE_ID
-->

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 27 insertions(+), 18 deletions(-))
google-beta provider: Diff ( 2 files changed, 27 insertions(+), 18 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • compute

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 164 insertions(+), 18 deletions(-))
google-beta provider: Diff ( 4 files changed, 164 insertions(+), 18 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 23 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 127 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_disk (29 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_disk" "primary" {
  disk_encryption_key {
    raw_key_wo = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 22
Passed tests: 4
Skipped tests: 18
Affected tests: 0

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccComputeRegionDisk_regionDiskDiskEncryptionKeyWoExample
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 270 insertions(+), 18 deletions(-))
google-beta provider: Diff ( 5 files changed, 270 insertions(+), 18 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 23 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 127 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccComputeRegionDisk_diskEncryptionKeyWoUpdate
  • TestAccComputeRegionDisk_regionDiskDiskEncryptionKeyWoExample
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 270 insertions(+), 18 deletions(-))
google-beta provider: Diff ( 5 files changed, 270 insertions(+), 18 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 25 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 127 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccComputeRegionDisk_diskEncryptionKeyWoUpdate
  • TestAccComputeRegionDisk_regionDiskDiskEncryptionKeyWoExample
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 270 insertions(+), 18 deletions(-))
google-beta provider: Diff ( 5 files changed, 270 insertions(+), 18 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 25 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 127 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccComputeRegionDisk_diskEncryptionKeyWoUpdate
  • TestAccComputeRegionDisk_regionDiskDiskEncryptionKeyWoExample
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@BBBmau BBBmau force-pushed the compute_region_disk_writeonly branch from 811082a to 5ac4377 Compare February 12, 2025 05:09
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 270 insertions(+), 18 deletions(-))
google-beta provider: Diff ( 5 files changed, 270 insertions(+), 18 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 25 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 127 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 239 insertions(+), 18 deletions(-))
google-beta provider: Diff ( 5 files changed, 239 insertions(+), 18 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 25 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 127 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccComputeRegionDisk_diskEncryptionKeyWoUpdate
  • TestAccComputeRegionDisk_regionDiskDiskEncryptionKeyWoExample
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 239 insertions(+), 18 deletions(-))
google-beta provider: Diff ( 5 files changed, 239 insertions(+), 18 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 25 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 127 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccComputeRegionDisk_diskEncryptionKeyWoUpdated
  • TestAccComputeRegionDisk_regionDiskDiskEncryptionKeyWoExample
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@BBBmau BBBmau force-pushed the compute_region_disk_writeonly branch from c527385 to e1a77d9 Compare February 13, 2025 06:48
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 236 insertions(+), 19 deletions(-))
google-beta provider: Diff ( 5 files changed, 236 insertions(+), 19 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 11 insertions(+), 2 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 127 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccComputeRegionDisk_diskEncryptionKeyWoUpdated
  • TestAccComputeRegionDisk_regionDiskDiskEncryptionKeyWoExample
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@BBBmau BBBmau marked this pull request as ready for review February 13, 2025 07:47
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 267 insertions(+), 19 deletions(-))
google-beta provider: Diff ( 5 files changed, 267 insertions(+), 19 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 11 insertions(+), 2 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 127 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 22
Passed tests: 4
Skipped tests: 18
Affected tests: 0

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccComputeRegionDisk_diskEncryptionKeyWoUpdated
  • TestAccComputeRegionDisk_regionDiskDiskEncryptionKeyWoExample
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants