Add labels property to HA VPN Gateway #12866

cynicphoenix · 2025-01-27T09:56:00Z

compute: added `labels` field to `google_compute_ha_vpn_gateway` resource

github-actions · 2025-01-27T09:56:58Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-01-27T10:07:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 230 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 230 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

modular-magician · 2025-01-27T10:10:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 230 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 230 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

modular-magician · 2025-01-27T10:26:39Z

Tests analytics

Total tests: 1097
Passed tests: 1005
Skipped tests: 75
Affected tests: 17

Click here to see the affected service packages

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-01-27T10:29:56Z

Tests analytics

Total tests: 1097
Passed tests: 1005
Skipped tests: 75
Affected tests: 17

Click here to see the affected service packages

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-01-27T10:34:08Z

🟢 Tests passed during RECORDING mode:
TestAccComputeHaVpnGateway_haVpnGatewayBasicExample [Debug log]
TestAccComputeHaVpnGateway_haVpnGatewayIpv6Example [Debug log]
TestAccComputeRouterInterface_withTunnel [Debug log]
TestAccComputeRouterPeer_AddMd5AuthenticationKey [Debug log]
TestAccComputeRouterPeer_EnableDisableIpv6 [Debug log]
TestAccComputeRouterPeer_Ipv4BasicCreateUpdate [Debug log]
TestAccComputeRouterPeer_Ipv6Basic [Debug log]
TestAccComputeRouterPeer_UpdateIpv6Address [Debug log]
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey [Debug log]
TestAccComputeRouterPeer_addImportAndExportPolicy [Debug log]
TestAccComputeRouterPeer_advertiseMode [Debug log]
TestAccComputeRouterPeer_basic [Debug log]
TestAccComputeRouterPeer_bfd [Debug log]
TestAccComputeRouterPeer_enable [Debug log]
TestAccComputeVpnTunnel_router [Debug log]
TestAccDataSourceComputeHaVpnGateway [Debug log]
TestAccDataSourceComputeRouterStatus [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2025-01-27T10:37:15Z

🟢 Tests passed during RECORDING mode:
TestAccComputeHaVpnGateway_haVpnGatewayBasicExample [Debug log]
TestAccComputeHaVpnGateway_haVpnGatewayIpv6Example [Debug log]
TestAccComputeRouterInterface_withTunnel [Debug log]
TestAccComputeRouterPeer_AddMd5AuthenticationKey [Debug log]
TestAccComputeRouterPeer_EnableDisableIpv6 [Debug log]
TestAccComputeRouterPeer_Ipv4BasicCreateUpdate [Debug log]
TestAccComputeRouterPeer_Ipv6Basic [Debug log]
TestAccComputeRouterPeer_UpdateIpv6Address [Debug log]
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey [Debug log]
TestAccComputeRouterPeer_addImportAndExportPolicy [Debug log]
TestAccComputeRouterPeer_advertiseMode [Debug log]
TestAccComputeRouterPeer_basic [Debug log]
TestAccComputeRouterPeer_bfd [Debug log]
TestAccComputeRouterPeer_enable [Debug log]
TestAccComputeVpnTunnel_router [Debug log]
TestAccDataSourceComputeHaVpnGateway [Debug log]
TestAccDataSourceComputeRouterStatus [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2025-01-27T10:37:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 230 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 230 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

harshithpatte-g · 2025-01-27T10:39:09Z

@cynicphoenix if label fields are mutable, can we add update tests?

modular-magician · 2025-01-27T10:57:55Z

Tests analytics

Total tests: 1097
Passed tests: 1022
Skipped tests: 75
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2025-01-30T04:53:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 296 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 296 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

modular-magician · 2025-01-30T04:55:30Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccComputeHaVpnGateway_updateLabels
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2025-01-30T05:03:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 293 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 293 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

modular-magician · 2025-01-30T05:06:00Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccComputeHaVpnGateway_updateLabels
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2025-01-30T05:12:31Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 294 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 294 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

modular-magician · 2025-01-30T05:33:36Z

Tests analytics

Total tests: 1098
Passed tests: 1022
Skipped tests: 75
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-01-30T05:33:49Z

🔴 Tests failed during RECORDING mode:
TestAccComputeHaVpnGateway_updateLabels [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

shuyama1 · 2025-01-31T20:20:31Z

mmv1/third_party/terraform/services/compute/resource_compute_ha_vpn_gateway_labels_test.go

@@ -0,0 +1,62 @@
+package compute_test


Please rename the test file to resource_compute_ha_vpn_gateway_test.go

shuyama1 · 2025-01-31T20:21:33Z

mmv1/third_party/terraform/services/compute/resource_compute_ha_vpn_gateway_labels_test.go

+resource "google_compute_ha_vpn_gateway" "ha_gateway1" {
+  region   = "us-central1"
+  name     = "tf-test-ha-vpn-1%s"
+  network  = google_compute_network.network1.id


Test failed with the following error:

resource_compute_ha_vpn_gateway_labels_test.go:19: Step 1/4 error: Error running pre-apply refresh: exit status 1 Error: Reference to undeclared resource on terraform_plugin_test.tf line 5, in resource "google_compute_ha_vpn_gateway" "ha_gateway1": 5: network = google_compute_network.network1.id A managed resource "google_compute_network" "network1" has not been declared in the root module.

You'll need to create a dependent resource google_compute_network inline so it can be referenced. Please see the generated tests as examples. https://github.com/hashicorp/terraform-provider-google-beta/blob/main/google-beta/services/compute/resource_compute_ha_vpn_gateway_generated_test.go#L66

Added network resource

modular-magician · 2025-02-03T12:30:44Z

Tests analytics

Total tests: 1101
Passed tests: 1025
Skipped tests: 75
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-02-03T12:32:40Z

🔴 Tests failed during RECORDING mode:
TestAccComputeHaVpnGateway_updateLabels [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-04T06:27:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 366 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 366 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

modular-magician · 2025-02-04T06:46:08Z

Tests analytics

Total tests: 1101
Passed tests: 1008
Skipped tests: 75
Affected tests: 18

Click here to see the affected service packages

Action taken

Found 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-02-04T06:53:27Z

🟢 Tests passed during RECORDING mode:
TestAccComputeHaVpnGateway_haVpnGatewayBasicExample [Debug log]
TestAccComputeHaVpnGateway_haVpnGatewayIpv6Example [Debug log]
TestAccComputeRouterInterface_withTunnel [Debug log]
TestAccComputeRouterPeer_AddMd5AuthenticationKey [Debug log]
TestAccComputeRouterPeer_EnableDisableIpv6 [Debug log]
TestAccComputeRouterPeer_Ipv4BasicCreateUpdate [Debug log]
TestAccComputeRouterPeer_Ipv6Basic [Debug log]
TestAccComputeRouterPeer_UpdateIpv6Address [Debug log]
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey [Debug log]
TestAccComputeRouterPeer_addImportAndExportPolicy [Debug log]
TestAccComputeRouterPeer_advertiseMode [Debug log]
TestAccComputeRouterPeer_basic [Debug log]
TestAccComputeRouterPeer_bfd [Debug log]
TestAccComputeRouterPeer_enable [Debug log]
TestAccComputeVpnTunnel_router [Debug log]
TestAccDataSourceComputeHaVpnGateway [Debug log]
TestAccDataSourceComputeRouterStatus [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccComputeHaVpnGateway_updateLabels [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

mmv1/products/compute/HaVpnGateway.yaml

mmv1/third_party/terraform/services/compute/resource_compute_ha_vpn_gateway_test.go

cynicphoenix · 2025-02-05T06:40:29Z

Hey @shuyama1 I was testing some changes as the test was failing. Test seems to be correct.
I investigated and found that the update label/set label is not working via gCloud, or even through gCurl (directly hitting REST APIs).

cynicphoenix · 2025-02-07T07:00:25Z

Created a bug for update label issue in vpn gateways: b/394492874
Removed update-label test from this PR. Created a new bug for update-label test for vpn gateways: b/392769050
Will add update-label test once update-label issue is resolved.

modular-magician · 2025-02-07T07:24:38Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 232 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 6 files changed, 232 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

modular-magician · 2025-02-07T07:44:46Z

Tests analytics

Total tests: 1101
Passed tests: 1024
Skipped tests: 75
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-02-07T07:46:54Z

🟢 Tests passed during RECORDING mode:
TestAccComputeHaVpnGateway_haVpnGatewayBasicExample [Debug log]
TestAccComputeHaVpnGateway_haVpnGatewayIpv6Example [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

shuyama1

Mostly LGTM. Only one small comment, thank you!

shuyama1 · 2025-02-11T19:24:26Z

mmv1/templates/terraform/examples/ha_vpn_gateway_basic.tf.tmpl

@@ -2,6 +2,9 @@ resource "google_compute_ha_vpn_gateway" "ha_gateway1" {
  region   = "us-central1"
  name     = "{{index $.Vars "ha_vpn_gateway1_name"}}"
  network  = google_compute_network.network1.id
+  labels = {


We'd aim for only minimal configuration in the basic example - including only required fields. It would be fine to have test coverage in ha_vpn_gateway_ipv6 only

modular-magician · 2025-02-12T06:52:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 224 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 224 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 3 insertions(+))

modular-magician · 2025-02-12T07:12:11Z

Tests analytics

Total tests: 1105
Passed tests: 1029
Skipped tests: 75
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-02-12T07:14:20Z

🟢 Tests passed during RECORDING mode:
TestAccComputeHaVpnGateway_haVpnGatewayBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

Add labels property to HA VPN Gateway

100478d

github-actions bot requested a review from shuyama1 January 27, 2025 09:56

Fix Lint

9568c18

modular-magician added the service/compute-vpn label Jan 27, 2025

Fix update url

e09c169

cynicphoenix marked this pull request as draft January 27, 2025 11:14

cynicphoenix added 2 commits January 30, 2025 04:42

Add update test

69827de

Fix

74c4a47

Fix

484a8e7

cynicphoenix marked this pull request as ready for review January 30, 2025 05:29

shuyama1 requested changes Jan 31, 2025

View reviewed changes

Review changes

89dcc67

github-actions bot requested a review from shuyama1 February 3, 2025 06:15

Add custom code

0362b03

shuyama1 reviewed Feb 5, 2025

View reviewed changes

mmv1/products/compute/HaVpnGateway.yaml Outdated Show resolved Hide resolved

mmv1/products/compute/HaVpnGateway.yaml Show resolved Hide resolved

mmv1/third_party/terraform/services/compute/resource_compute_ha_vpn_gateway_test.go Outdated Show resolved Hide resolved

cynicphoenix marked this pull request as draft February 5, 2025 04:36

Remove update-labels

140bb12

cynicphoenix requested a review from shuyama1 February 11, 2025 04:41

shuyama1 marked this pull request as ready for review February 11, 2025 17:24

shuyama1 reviewed Feb 11, 2025

View reviewed changes

Rview changes

eddf74a

github-actions bot requested a review from shuyama1 February 12, 2025 06:41

shuyama1 approved these changes Feb 12, 2025

View reviewed changes

shuyama1 added this pull request to the merge queue Feb 12, 2025

Merged via the queue into GoogleCloudPlatform:main with commit 2346615 Feb 12, 2025
22 checks passed

Add labels property to HA VPN Gateway #12866

Add labels property to HA VPN Gateway #12866

Conversation

cynicphoenix commented Jan 27, 2025 • edited by shuyama1 Loading

github-actions bot commented Jan 27, 2025

modular-magician commented Jan 27, 2025

Diff report

modular-magician commented Jan 27, 2025

Diff report

modular-magician commented Jan 27, 2025

Tests analytics

Action taken

modular-magician commented Jan 27, 2025

Tests analytics

Action taken

modular-magician commented Jan 27, 2025

modular-magician commented Jan 27, 2025

modular-magician commented Jan 27, 2025

Diff report

harshithpatte-g commented Jan 27, 2025

modular-magician commented Jan 27, 2025

Tests analytics

modular-magician commented Jan 30, 2025

Diff report

modular-magician commented Jan 30, 2025

Tests analytics

modular-magician commented Jan 30, 2025

Diff report

modular-magician commented Jan 30, 2025

Tests analytics

modular-magician commented Jan 30, 2025

Diff report

modular-magician commented Jan 30, 2025

Tests analytics

Action taken

modular-magician commented Jan 30, 2025

shuyama1 Jan 31, 2025

Choose a reason for hiding this comment

cynicphoenix Feb 3, 2025

Choose a reason for hiding this comment

shuyama1 Jan 31, 2025

Choose a reason for hiding this comment

cynicphoenix Feb 3, 2025

Choose a reason for hiding this comment

modular-magician commented Feb 3, 2025

Tests analytics

Action taken

modular-magician commented Feb 3, 2025

modular-magician commented Feb 4, 2025

Diff report

modular-magician commented Feb 4, 2025

Tests analytics

Action taken

modular-magician commented Feb 4, 2025

cynicphoenix commented Feb 5, 2025

cynicphoenix commented Feb 7, 2025

modular-magician commented Feb 7, 2025

Diff report

modular-magician commented Feb 7, 2025

Tests analytics

Action taken

modular-magician commented Feb 7, 2025

shuyama1 left a comment

Choose a reason for hiding this comment

shuyama1 Feb 11, 2025

Choose a reason for hiding this comment

cynicphoenix Feb 12, 2025

Choose a reason for hiding this comment

modular-magician commented Feb 12, 2025

Diff report

modular-magician commented Feb 12, 2025

Tests analytics

Action taken

modular-magician commented Feb 12, 2025

cynicphoenix commented Jan 27, 2025 •

edited by shuyama1

Loading