Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMEK support for Redis cluster #12999

Merged
merged 18 commits into from
Feb 14, 2025

Conversation

himanikh
Copy link
Contributor

@himanikh himanikh commented Feb 7, 2025

Adds CMEK support to Redis cluster resource

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

redis: added `kms_key` field to `google_redis_cluster` resource

Copy link

github-actions bot commented Feb 7, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from melinath February 7, 2025 18:18
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 261 insertions(+), 71 deletions(-))
google-beta provider: Diff ( 5 files changed, 261 insertions(+), 71 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 9 files changed, 191 insertions(+), 35 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster" "primary" {
  kms_key = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 30
Passed tests: 29
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisCluster_redisClusterCmekExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccRedisCluster_redisClusterCmekExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@melinath melinath changed the title Add CMEK support Add CMEK support for Redis cluster Feb 7, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 261 insertions(+), 71 deletions(-))
google-beta provider: Diff ( 5 files changed, 261 insertions(+), 71 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 9 files changed, 191 insertions(+), 35 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 30
Passed tests: 29
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisCluster_redisClusterCmekExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccRedisCluster_redisClusterCmekExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 261 insertions(+), 71 deletions(-))
google-beta provider: Diff ( 5 files changed, 261 insertions(+), 71 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 9 files changed, 191 insertions(+), 35 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 30
Passed tests: 29
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisCluster_redisClusterCmekExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccRedisCluster_redisClusterCmekExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 265 insertions(+), 71 deletions(-))
google-beta provider: Diff ( 5 files changed, 265 insertions(+), 71 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 9 files changed, 193 insertions(+), 35 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 30
Passed tests: 29
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisCluster_redisClusterCmekExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccRedisCluster_redisClusterCmekExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 267 insertions(+), 71 deletions(-))
google-beta provider: Diff ( 5 files changed, 267 insertions(+), 71 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 9 files changed, 194 insertions(+), 35 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 30
Passed tests: 29
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisCluster_redisClusterCmekExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccRedisCluster_redisClusterCmekExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 267 insertions(+), 71 deletions(-))
google-beta provider: Diff ( 5 files changed, 267 insertions(+), 71 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 9 files changed, 194 insertions(+), 35 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 30
Passed tests: 29
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisCluster_redisClusterCmekExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccRedisCluster_redisClusterCmekExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 30
Passed tests: 29
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisCluster_redisClusterCmekExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccRedisCluster_redisClusterCmekExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

mmv1/products/redis/Cluster.yaml Outdated Show resolved Hide resolved
mmv1/products/redis/Cluster.yaml Show resolved Hide resolved
mmv1/products/redis/Cluster.yaml Show resolved Hide resolved
himanikh and others added 2 commits February 11, 2025 12:18
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
@github-actions github-actions bot requested a review from melinath February 11, 2025 20:19
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
@github-actions github-actions bot requested a review from melinath February 11, 2025 20:36
mmv1/products/redis/Cluster.yaml Outdated Show resolved Hide resolved
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
@github-actions github-actions bot requested a review from melinath February 12, 2025 01:15
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 264 insertions(+), 95 deletions(-))
google-beta provider: Diff ( 5 files changed, 264 insertions(+), 95 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 9 files changed, 189 insertions(+), 47 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 30
Passed tests: 29
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisCluster_redisClusterCmekExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccRedisCluster_redisClusterCmekExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 262 insertions(+), 95 deletions(-))
google-beta provider: Diff ( 5 files changed, 262 insertions(+), 95 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 9 files changed, 188 insertions(+), 47 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 30
Passed tests: 29
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisCluster_redisClusterCmekExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccRedisCluster_redisClusterCmekExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants