Skip to content

Commit

Permalink
test: Enable min/max high epoch seconds tests
Browse files Browse the repository at this point in the history
  • Loading branch information
nj1973 committed Jan 22, 2025
1 parent 74685e7 commit 1c60e5f
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 18 deletions.
5 changes: 2 additions & 3 deletions tests/system/data_sources/test_mysql.py
Original file line number Diff line number Diff line change
Expand Up @@ -301,12 +301,11 @@ def test_column_validation_tricky_dates_to_bigquery():
values for UNIX_TIMESTAMP() is '1970-01-01 00:00:01.000000' UTC to
3001-01-19 03:14:07.999999' UTC (corresponding to 32536771199.999999 seconds)."
"""
# TODO We can uncomment the min/max lines below once issue-1396 has been resolved.
column_validation_test(
tc="bq-conn",
tables="pso_data_validator.dvt_tricky_dates",
# min_cols="*",
# max_cols="*",
min_cols="*",
max_cols="*",
sum_cols="col_dt_epoch,col_ts_epoch",
wildcard_include_timestamp=True,
)
Expand Down
5 changes: 2 additions & 3 deletions tests/system/data_sources/test_oracle.py
Original file line number Diff line number Diff line change
Expand Up @@ -396,13 +396,12 @@ def test_column_validation_view_core_types_vw():
)
def test_column_validation_tricky_dates_to_bigquery():
"""Test with date values that are at the extremes, e.g. 9999-12-31."""
# TODO We can uncomment the min/max lines below once issue-1396 has been resolved.
# TODO We can uncomment the sum line below once issue-1391 has been resolved.
column_validation_test(
tc="bq-conn",
tables="pso_data_validator.dvt_tricky_dates",
# min_cols="*",
# max_cols="*",
min_cols="*",
max_cols="*",
# sum_cols="*",
wildcard_include_timestamp=True,
)
Expand Down
5 changes: 2 additions & 3 deletions tests/system/data_sources/test_postgres.py
Original file line number Diff line number Diff line change
Expand Up @@ -987,12 +987,11 @@ def test_column_validation_group_by_timestamp():
)
def test_column_validation_tricky_dates_to_bigquery():
"""Test with date values that are at the extremes, e.g. 9999-12-31."""
# TODO We can uncomment the min/max lines below once issue-1396 has been resolved.
column_validation_test(
tc="bq-conn",
tables="pso_data_validator.dvt_tricky_dates",
# min_cols="*",
# max_cols="*",
min_cols="*",
max_cols="*",
sum_cols="*",
wildcard_include_timestamp=True,
)
Expand Down
5 changes: 2 additions & 3 deletions tests/system/data_sources/test_snowflake.py
Original file line number Diff line number Diff line change
Expand Up @@ -257,12 +257,11 @@ def test_column_validation_core_types_to_bigquery():
)
def test_column_validation_tricky_dates_to_bigquery():
"""Test with date values that are at the extremes, e.g. 9999-12-31."""
# TODO We can uncomment the min/max lines below once issue-1396 has been resolved.
column_validation_test(
tc="bq-conn",
tables="PSO_DATA_VALIDATOR.PUBLIC.DVT_TRICKY_DATES=pso_data_validator.dvt_tricky_dates",
# min_cols="*",
# max_cols="*",
min_cols="*",
max_cols="*",
sum_cols="*",
wildcard_include_timestamp=True,
)
Expand Down
5 changes: 2 additions & 3 deletions tests/system/data_sources/test_sql_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -344,12 +344,11 @@ def test_column_validation_core_types_to_bigquery():
)
def test_column_validation_tricky_dates_to_bigquery():
"""Test with date values that are at the extremes, e.g. 9999-12-31."""
# TODO We can uncomment the min/max lines below once issue-1396 has been resolved.
column_validation_test(
tc="bq-conn",
tables="pso_data_validator.dvt_tricky_dates",
# min_cols="*",
# max_cols="*",
min_cols="*",
max_cols="*",
sum_cols="*",
wildcard_include_timestamp=True,
)
Expand Down
5 changes: 2 additions & 3 deletions tests/system/data_sources/test_teradata.py
Original file line number Diff line number Diff line change
Expand Up @@ -394,12 +394,11 @@ def test_column_validation_tricky_dates_to_bigquery():
# https://support.teradata.com/knowledge?id=kb_article_view&sys_kb_id=0e81918ac36da9103eb2d88f05013138
"""
cols = "col_dt_low,col_dt_epoch,col_dt_high,col_ts_low,col_ts_epoch"
# TODO We can uncomment the min/max lines below once issue-1396 has been resolved.
column_validation_test(
tc="bq-conn",
tables="udf.dvt_tricky_dates=pso_data_validator.dvt_tricky_dates",
# min_cols=cols,
# max_cols=cols,
min_cols=cols,
max_cols=cols,
sum_cols=cols,
wildcard_include_timestamp=True,
)
Expand Down

0 comments on commit 1c60e5f

Please sign in to comment.