Delete examples/dataflow-python-examples (6 examples) #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rachelgagnon ! To be clear, the client library in question was I'm +1 to this change, given that the examples in the Beam repo cover the concepts in these examples, and also have maintained integration tests. cc: @ryanmcdowell and @iht for additional opinions as well |
svetakvsundhar
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes 6 examples (within dataflow-python-examples/ subdir):
Streaming - Slowly Changing Side Input: with updated Beam and Python versions, pipeline failed 2/8 unit tests written by original author.
CC: @prathapreddy123
For the following pipeline examples, all failed to compile with latest BigQuery client libraries.
Batch - Ingesting Data from File to BQ
Batch - Transforming Data in Dataflow
Batch - Joining file and BQ Datasets in Dataflow
Batch - Ingest data using file structure in Datastore
Batch - Data Lake to Data Mart
CC: @robertwb
Updated examples are welcome - please create a new PR for each example and include a README.md with instructions to run each, took me a little while to figure out how to run each example here.