chore: add runtime hints for sql autoconfigure and sql-mysql samples to native ci #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhumin8
changed the title
zhumin8
changed the title
| @@ -168,6 +168,7 @@ jobs: | |||
| verify | |||
| env: | |||
| DB_PASSWORD: ${{ secrets.SPRING_CLOUD_GCP_CI_DB_ROOT_PASSWORD }} | |||
| GOOGLE_CLOUD_PROJECT: spring-cloud-gcp-ci | |||
There was a problem hiding this comment.
Why is the GOOGLE_CLOUD_PROJECT needed here, but not in the equivalent native env block? Both use setup-gcloud to set the project_id.
There was a problem hiding this comment.
Good question. On a second look, I updated this pr to use GCP_PROJECT which is commonly setup in both workflows.
IntegrationTest.yaml is using "google-github-actions/setup-gcloud@v0" vs. NativeTests.yaml using "google-github-actions/setup-gcloud@v1". That might have caused the slight difference in env vars setup.
Integration
CLOUDSDK_METRICS_ENVIRONMENT: github-actions-setup-gcloud
GCLOUD_PROJECT: spring-cloud-gcp-ci
CLOUDSDK_CORE_PROJECT: spring-cloud-gcp-ci-native
CLOUDSDK_PROJECT: spring-cloud-gcp-ci-native
GCLOUD_PROJECT: spring-cloud-gcp-ci-native
GCP_PROJECT: spring-cloud-gcp-ci-native
GOOGLE_CLOUD_PROJECT: spring-cloud-gcp-ci-native
CLOUDSDK_METRICS_ENVIRONMENT: github-actions-setup-gcloud
CLOUDSDK_METRICS_ENVIRONMENT_VERSION: 1.1.1
I'll raise a separate pr to upgrade this github action version for integration yaml.
| @@ -160,6 +162,8 @@ jobs: | |||
| id: intTest | |||
| run: | | |||
| MODULE_UNDER_TEST="${{ matrix.it }}" ./.github/workflows/scripts/native-image-tests.sh | |||
| env: | |||
| DB_PASSWORD: ${{ secrets.SPRING_CLOUD_GCP_CI_NATIVE_DB_ROOT_PASSWORD }} | |||
burkedavison
approved these changes
Nov 29, 2023
|
Kudos, SonarCloud Quality Gate passed! |
zhumin8
added a commit
that referenced
this pull request
Nov 30, 2023
Followup to comment [here](#2384 (comment)), upgrades `google-github-actions/setup-gcloud` to be consistent with [nativeTests.yaml](https://github.com/GoogleCloudPlatform/spring-cloud-gcp/blob/main/.github/workflows/NativeTests.yaml) following example [here](https://github.com/google-github-actions/setup-gcloud#service-account-key-json). This also fixes deprecation warnings on integration test workflows. ``` "service_account_key" has been deprecated. Please switch to using google-github-actions/auth which supports both Workload Identity Federation and Service Account Key JSON authentication. For more details, see https://github.com/google-github-actions/setup-gcloud#authorization ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
Add runtime hints for
GcpCloudSqlProperties.classin sql autoconfigure.Other changes:
sql-mysql-sample,sql-postgres-sampleandsql-postgres-r2dbc-sampleto native ci.maven-surefire-plugininnativeTestprofile.)spring-cloud-gcp-ciproject and native tests run inspring-cloud-gcp-ci-nativeproject.Todos: