feat: use a gitlab repository for config-sync-repo #328
+354
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caetano-colin
changed the title
caetano-colin
requested review from
apeabody,
sleighton2022,
yliaog and
a team
as code owners
apeabody
reviewed
Jan 23, 2025
| Command: "kubectl", | ||
| Args: args, | ||
| } | ||
| return shell.RunCommandAndGetStdOutE(t, kubectlCmd) |
There was a problem hiding this comment.
For kubectl I recommend using "github.com/gruntwork-io/terratest/modules/k8s":
k8sOpts := k8s.KubectlOptions{}
configNameSpace, err := k8s.RunKubectlAndGetOutputE(t, &k8sOpts, "get", "ns", "config-management-system", "-o", "json")
assert.NoError(err)
If you are testing (get credentials) in parallel, you can also specify the exact cluster content
k8sOpts := k8s.NewKubectlOptions(fmt.Sprintf("gke_%s_%s_%s", projectId, location, clusterName), "", "")
…erraform-google-enterprise-application into use-gitlab-fleetscope-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.