Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Shadow Jar on Java 19 #29

Closed
wants to merge 2 commits into from

Conversation

Goooler
Copy link
Owner

@Goooler Goooler commented Feb 8, 2024

Try to repro GradleUp/shadow#877.

@Goooler
Copy link
Owner Author

Goooler commented Feb 8, 2024

Shadow plugin 8.1.1 works well with Java 19, CI failure due to integration tests, see

> Task :shadowJar
Warning in /home/runner/work/StringResExporter/StringResExporter/build/libs/string-res-exporter-0.2.0-SNAPSHOT-all.jar:META-INF/services/org.apache.poi.extractor.ExtractorProvider:

https://scans.gradle.com/s/5dceyafzhjl5w/tests/overview?outcome=FAILED

@Goooler Goooler force-pushed the shadow-jar-relocation-issue-repro branch from 5460b5b to f2fec1c Compare February 8, 2024 11:34
@Goooler
Copy link
Owner Author

Goooler commented Feb 8, 2024

Relocation works well with intenal.jar, which includes classes with the byte code version 63.

@Goooler Goooler closed this Feb 8, 2024
@Goooler Goooler deleted the shadow-jar-relocation-issue-repro branch February 8, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant