Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #760 add property gmail.project_name #762

Closed
wants to merge 4 commits into from
Closed

Issue #760 add property gmail.project_name #762

wants to merge 4 commits into from

Conversation

StephanMeijer
Copy link
Contributor

No description provided.

@StephanMeijer StephanMeijer mentioned this pull request Oct 6, 2020
Closed
ryneeverett
ryneeverett requested changes Oct 11, 2020
View reviewed changes
@StephanMeijer
Copy link
Contributor Author

@ryneeverett Changed!

@ryneeverett
Copy link
Collaborator

So long as project_name is not in "Common Service Configuration Options" implemented across all services (which it probably should be) it seems like it ought to be documented somewhere in the gmail docs, no?

@StephanMeijer
Copy link
Contributor Author

Where would you document it, if not in the Example Service?

@ryneeverett
Copy link
Collaborator

I'd add a Service Features section and a subsection like in versionone. I'd be fine with you just copy/pasting that if you so choose.

@StephanMeijer
Copy link
Contributor Author

@ryneeverett Documentation like I did in #777?

@StephanMeijer
Copy link
Contributor Author

This can be closed, see #778 / #776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryneeverett ryneeverett Awaiting requested review from ryneeverett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StephanMeijer @ryneeverett