Improve performance of taskdb::apply_operations
#533
+169
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing implementation performed a `txn.get_task` and `txn.set_task` for each update operation. But typically, a sequence of operations will all apply to the same task, so most of these calls are redundant. This introduces a small cache of tasks to which some update operations have been applied (or which are known to not exist), avoiding the redundant calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation performed a
txn.get_taskandtxn.set_taskfor each update operation. But typically, a sequence of operations will all apply to the same task, so most of these calls are redundant.This introduces a small cache of tasks to which some update operations have been applied (or which are known to not exist), avoiding the redundant calls.
This should speed up application of changes during
task modify, especially when applied to multiple tasks.