-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of recipe-scrapers for web imports #27
Merged
cydanil
merged 20 commits into
GourmandRecipeManager:main
from
cydanil:feat/recipe_scrapers
Sep 4, 2021
Merged
Make use of recipe-scrapers for web imports #27
cydanil
merged 20 commits into
GourmandRecipeManager:main
from
cydanil:feat/recipe_scrapers
Sep 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove validate_ingdic
This pull request fixes 28 alerts when merging 096a581 into 5719ba1 - view on LGTM.com fixed alerts:
|
I'll merge this, and address the failing CI in the next MR in order to make the changes more readable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to deprecate existing web importer plugins and replace them with a single unified importer leveraging
recipe-scrapers
, as described in #18 .This MR is rather large and part 1 of the implementation: the functionality works as intended, but user feedback is lacking.
The import UI was reworked in a single dialog for web and file imports by introducing a
URIDialog
class.All previous web importers were deleted.
How Has This Been Tested?
This was tested by importing web and file recipes.
A basic integration test was added.
Screenshots (if appropriate):
Types of changes
Checklist: