Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navbar update #60

Merged
merged 1 commit into from
Apr 30, 2023
Merged

navbar update #60

merged 1 commit into from
Apr 30, 2023

Conversation

tthanhh-to
Copy link
Collaborator

nav bar is pinned, but covers some elements

@mpadil18
Copy link
Collaborator

mpadil18 commented Oct 6, 2022

Hi, Thanh, great work!

  1. The navbar couldn't overlap the events and faq section since they were made with components from Material-UI, which has its own CSS properties that make them overlay elements by default (more info here).
    You can fix this by adding z-index: 10; as a property to the .navigation-container in NavigationBar.scss. This helps us control which elements we want to place in ‘front’ of the screen. Elements with higher z-indexes will take more precedence over elements with lower ones, so we just need to give the navbar a relatively high z-index so it can overlay even Material-UI elements.
    (I tested using 2, which worked, but I like to make the z-index higher just in case we add any elements in the future that start to take precedence).

  2. Additionally, when the screen size is compressed to display the hamburger menu at the top, it appears to be a little cut off. Could we add more space between the menu icon and the edge of the browser window when the screen is smaller?

image

  1. Could we add “CONNECT US” at the very end of the navbar options? (per the new wireframe)

  2. Finally, when the user clicks on something in the navbar, they’re redirected, but the title of the section is cut off. Not sure if it's just my screen, but let me know.

image

Thank you so much!

@mpadil18
Copy link
Collaborator

We now have a final wireframe for the style of the navbar that we want to implement before the hackathon. There's really no difference between the new and previous navbar, but just thought it'd be helpful for you to see. :)

@mpadil18 mpadil18 merged commit bc5ed37 into dev Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants