Skip to content

Commit

Permalink
Add documentation for Solaris environ size fix when using daemon mode.
Browse files Browse the repository at this point in the history
  • Loading branch information
GrahamDumpleton committed Dec 15, 2017
1 parent 6c30f8b commit ba1fc6e
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
13 changes: 13 additions & 0 deletions docs/release-notes/version-4.5.24.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,16 @@ Version 4.5.24
Version 4.5.24 of mod_wsgi can be obtained from:

https://codeload.github.com/GrahamDumpleton/mod_wsgi/tar.gz/4.5.24

Bugs Fixed
----------

* Using mod_wsgi in daemon mode on Solaris would cause a process hang or
max out CPU usage. Caused by change of variable type to unsigned to get
rid of compiler warnings, without fixing how condition check using
variable was done.

Problem could also affect non Solaris systems if total number of HTTP
headers and other variables passed in WSGI environ was greater than 1024.
Affected Solaris all the time due to it having a limit of only 16 in
operating system for same code, meaning hit problem immediately.
1 change: 1 addition & 0 deletions src/server/mod_wsgi.c
Original file line number Diff line number Diff line change
Expand Up @@ -10717,6 +10717,7 @@ static apr_status_t wsgi_socket_sendv(apr_socket_t *sock, struct iovec *vec,

if (rv != APR_SUCCESS)
return rv;

if (nvec > iov_max) {
nvec -= iov_max;
offset += iov_max;
Expand Down

0 comments on commit ba1fc6e

Please sign in to comment.