Upgrading Cascade constraint to work with Grails 3.3 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having an issue with the registration Doesn't seem to be working like my other plugin...
The tests could be improved...
|
This would be very nice to have merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into several issue but got it working. I swapped out the AbstractVetoing constraint for a regular AbstractConstaint, which may not have been one of the issue, but since I got it working I didn't want to backtrack. I also got the unit tests working but they can be improved.
I plan on having a version of this in my command plugin, so I don't have to wait for this to be released for now. My command plugin and this plugin, complement each other.