tremulous: chat and colors overhaul #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement new message modes with the say menu for admin and clan chats. - Implement support for custom colors defined through a hexadecimal format, include both a short and long format for the hex support, that is ^#fff and ^##ffffff. - Remove extra color codes that are unused in player names. - Implement an escape from the color escape so that ^ can be printed by typing ^^. - Make it so that the length of names are minimally effected by the use of color codes. - Fix the display of colorful names in the HUD kill feed. - Have the printed line width in the console adjust with the resolution. - Implement 62 hardcoded standard chat colors. - Implement the command /colors - Have editable text fields preview colors while editing. - Implement an input history for the say menus. - Implement cycling through message modes with page up and page down. - Initial implementation of player mentions, and player tab completion in the say menu. - Have ctrl+c clear the current line of the say menu, when the say menu is open. - Make arrow down at the current line in the say menu clear the input, but if a writable key isn't pressed, don't completely delete the current line behind the scenes to allow up arrow to recover it. - When the say menu is exited with unsubmitted text, the next time the say menu is open, it would be in a pending blank state where you can recover the unsubmitted text with arrow up provided you didn't already press a printable key. - In the console make colors that are too dark appear brighter in the console so that they are more readable.
…ColorVecToAttrib().
…local headers for linux build
cengique
previously approved these changes
Mar 28, 2020
There was a problem hiding this comment.
Compiles (added some changes to Linux makefile section), runs, and works fine.
/colors command is a bit long. Maybe explanatory lines at the end can be listed without blank lines between them. Also, colors are sorted based on key, which is fine, but they could also be sorted by color, by name of color. But it is usable, so I approve it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include both a short and long format for the hex support, that is ^#fff and ^##ffffff.
the say menu.
a writable key isn't pressed, don't completely delete the current line
behind the scenes to allow up arrow to recover it.
menu is open, it would be in a pending blank state where you can recover
the unsubmitted text with arrow up provided you didn't already press a
printable key.
console so that they are more readable.