Importing distro files from Flatpak and Arch Linux

[cengique]

Imported packaging files and new screenshots @AsciiWolf

[AsciiWolf]

Looks much better now, thanks! :-)

[cengique]

@AsciiWolf just pushed some more commits, please review. Thanks! :)

[AsciiWolf]

Just a note: I may be wrong, but I think that the correct URL should be https://raw.githubusercontent.com/GrangerHub/tremulous/master/misc/grangerhub-trem1.3-7d1b.jpg.

Same with the other screenshots/videos.

[cengique]

Yeah, this sounds right. I used to be able to get those URLs but somehow I can't seem to get to them. But just using your example works (for existing files). I will re-confirm once I merge this PR to master.

[AsciiWolf]

Nice, I think it looks good now (except for the screenshots URL)! The only remaining thing are the Makefile rules. :-)

[AsciiWolf]

Although, we should probably sort through the screenshots, select the best ones and remove others. Currently, there are too many of them and some are very similar.

For example, misc/screenshots/c-fedora.png and misc/screenshots/d-fedora.png look almost the same.

[cengique]

Nice, I think it looks good now (except for the screenshots URL)! The only remaining thing are the Makefile rules. :-)

Great! I will sort through the screenshots, but I will need some help with the Makefile.

@wtfbbqhax @jkent can you help crafting an install section in the Makefile that can place binaries, icon, and desktop files in the proper places? As far as I see, we only have one target in the Makefile that just produces a zip or other file based on target distro. So we never worried about an install section. What's the situation with the CMake build? Was that ever working? Thanks!

[cengique]

Looks like libcurl is also outdated and causing Linux build errors due to USE_RESTCLIENT=1.

[cengique]

@AsciiWolf @jkent I added an install: target in the Makefile. I'd appreciate if you can review. Note that the game client is not perfectly working in this branch, so I'll rebase to a release branch to complete testing. I'm looking for general feedback about the changes in the Makefile. Thanks!

@AsciiWolf I removed screenshot d-fedora.png, but kept the newer ones as not all are referenced in the flatpak.

[AsciiWolf]

It looks good except the things that I pointed out. Thanks!

[AsciiWolf]

By the way, we have a CI build failure on Linux:

error: 'CURLMOPT_MAX_TOTAL_CONNECTIONS' conflicts with a previous declaration

Is it the same thing as already mentioned here?

[cengique]

By the way, we have a CI build failure on Linux:

error: 'CURLMOPT_MAX_TOTAL_CONNECTIONS' conflicts with a previous declaration

Is it the same thing as already mentioned here?

That's right, we will work on that separately, but for now you can build with:

USE_INTERNAL_LUA=1 make -j

by removing the building of the REST client.

[cengique]

@AsciiWolf I think I addressed all the issues. Please check! Thanks :)

[cengique]

@AsciiWolf just got around to fixing these issues. If you can check the conversations and resolve, we may be close to being done! If this is all good, I'll rebase this branch to a working release and do more testing.

[AsciiWolf]

Looks very good now (except the few things mentioned before), thanks! :-)

[AsciiWolf]

Any progress here?

[cengique]

Any progress here?

Thanks for the reminder @AsciiWolf ! I needed it. :)

I added a number of alien screenshots, in addition to fixing the other issues. Thanks as usual for checking and providing feedback.

Once we're done here, I think I need to update so that we can build the flatpak for 0.15. Any other next steps?

[cengique]

@AsciiWolf removed URL from appdata as requested. I posted a comment above regarding screenshots.

I also corrected the Github Actions for the Linux build, which may help with fixing the issues while building the Flatpak.

[AsciiWolf]

Thanks! Everything looks good to me now. :-)