New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when ungrouping a direct child of the root in debug mode #2241

Open

0HyperCube wants to merge 1 commit into master from debug-mode-ungroup-crash

Member

0HyperCube commented Jan 30, 2025

As reported by @Keavon.

I'm not sure why it is bad for to_node() to be run on the root node in debug mode.

debug_assert!(id != NodeId(0), "LayerNodeIdentifier::ROOT_PARENT cannot be converted to NodeId");

This PR simply works around the issue


          Fix crash when ungrouping a child of the root in debug mode

3d17e1e

github-actions bot deployed to graphite-dev (Preview)

January 30, 2025 21:49

View deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet