Instance tables refactor part 4: flatten groups to use the instance tables instead #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename method one_item to one_instance
…eMut<T> Move the Instance<T> methods over to providing an Instance<T>/InstanceMut<T>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 4 of #1834.
Flattens
GraphicGroupandArtboardGroupstructs, placing theirVecdata into rows of theirInstances<GraphicElement>andInstances<Artboard>tables.This PR is based on top of #2256. The first commit in the chain of this PR's changes is 39f98b1. This PR is blocked on that PR being merged first.