Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.23 #2058

Merged
merged 60 commits into from
May 17, 2024
Merged
Changes from 1 commit
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
04786c5
correct format for decimals and dots
omarkasem Jul 23, 2023
5d00293
fix tests issue
omarkasem Oct 10, 2023
8b8fb85
tests
omarkasem Oct 10, 2023
724598a
tests
omarkasem Oct 10, 2023
7f7f01a
fix tests
omarkasem Oct 11, 2023
7b6a4eb
Merge branch 'develop' into issue/1872-incorrect-display-of-the-numbe…
mrcasual Mar 20, 2024
c01bb98
new fix
omarkasem Mar 27, 2024
fd362db
new fix
omarkasem Mar 27, 2024
a1c8aac
return if
omarkasem Mar 27, 2024
3862885
fix comma issue by editing wp_locale decimal point and thousands sep …
omarkasem Mar 27, 2024
5743c30
remove wp_locale and use the number_format function directly to adjus…
omarkasem Mar 27, 2024
3cd0696
adjust decimal formatting and use gv instead of GFFormsModel
omarkasem Mar 28, 2024
aaa835b
Make approval link text filterable
karlemilnikka Apr 21, 2024
35cc606
Add GPNF merge tags for views.
doekenorg Apr 8, 2024
a0c433f
Register custom meta tags.
doekenorg Apr 8, 2024
da65e57
Add fields top field modal
doekenorg Apr 8, 2024
7998d6d
Fix missing secret on nested views.
doekenorg Apr 22, 2024
7f95583
Added Child Form Field merge tag
doekenorg Apr 22, 2024
2289774
Configure Composer to install Foundation from ZIP file
mrcasual Apr 22, 2024
c7e4ece
Update developer instructions [ci skip]
mrcasual Apr 22, 2024
307f03c
Remove acceptance tests
mrcasual Apr 22, 2024
f66a034
Remove old unit test setup
mrcasual Apr 22, 2024
3826ce2
Update developer instructions [ci skip]
mrcasual Apr 22, 2024
7cb9018
Ignore readme.md from secret scanning
zackkatz Apr 22, 2024
3efbee3
Ignore secret scanning in readme.md (take 2)
zackkatz Apr 22, 2024
fb074c2
Delete .github/.github directory
zackkatz Apr 22, 2024
062e934
Fix CircleCI badge in readme.md [ci skip]
mrcasual Apr 22, 2024
bdf6404
trigger build
mrcasual Apr 22, 2024
73e1740
Update repo's readme.md [ci skip]
mrcasual Apr 22, 2024
4e641c0
Allow modifying entry approval link url, text and other parameters
mrcasual Apr 22, 2024
a98e63d
Fix test_frontend_field_html_number test by adding the correct number…
omarkasem Apr 23, 2024
a4e0433
Merge branch 'develop' into issue/1872-incorrect-display-of-the-numbe…
mrcasual Apr 24, 2024
bf723a1
Fix export link widget by sanitizing link
doekenorg Apr 25, 2024
379a29c
Fix readme entry [ci skip]
doekenorg Apr 25, 2024
add7cad
Merge pull request #1 from mrcasual/develop
karlemilnikka Apr 25, 2024
225a797
Make approval link text filterable (#2031)
mrcasual Apr 29, 2024
fa45dce
Allow returning raw URL for entry approval and search clear links
mrcasual Apr 29, 2024
daac01f
Remove unnecessary null coalescing in condition check [ci skip]
mrcasual Apr 29, 2024
f6a233f
Merge branch 'develop' into issues/2034-fatal-error-on-csv-export-wid…
mrcasual Apr 29, 2024
9c0b589
Fix export link widget by sanitizing link (#2035) [ci skip]
mrcasual Apr 29, 2024
c0cdebb
Support for nested forms entry meta (#2032) [ci skip]
mrcasual Apr 29, 2024
1c392ae
Update changelog & docblocks [ci skip]
mrcasual Apr 29, 2024
001babf
Update Foundation to v1.2.13
mrcasual Apr 30, 2024
c715257
Update changelog [ci skip]
mrcasual Apr 30, 2024
3be2378
Check for Gravity Flow presence before adding hooks
mrcasual May 1, 2024
e005343
Fix default value of showing incorrectly
omarkasem May 2, 2024
abb15de
Fix textdomain
zackkatz May 3, 2024
6c27e13
Add tests for decimal comma format with default, number_format and de…
omarkasem May 3, 2024
d432a33
Add another scenario of comma type field test
omarkasem May 3, 2024
83207a5
Add gitignore .phpunit cache file
omarkasem May 3, 2024
cb786ea
Add a new possible test for decimal dot
omarkasem May 3, 2024
f056f49
Update repo's readme.md [ci skip]
mrcasual May 7, 2024
87e25eb
Display description for select and text fields in View editor metabox
mrcasual May 11, 2024
d42e655
Fix number formatting according to the form field setting (#1879)
mrcasual May 12, 2024
3a09cab
Fix entry duplication not busting View cache
mrcasual May 13, 2024
8a144e1
Update changelog
mrcasual May 13, 2024
adeab1c
Update Foundation to v1.2.14
mrcasual May 17, 2024
0101ae0
Bump version to 2.23 & update changelog
mrcasual May 17, 2024
569207a
Fix View caching issues when updating entries on a joined form
mrcasual May 17, 2024
6a235f9
Make "Add All Form Fields" button add fields in correct order (#2052)
mrcasual May 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
new fix
omarkasem committed Mar 27, 2024
commit c01bb9881ddfecb29b288c067ded018875377629
18 changes: 13 additions & 5 deletions templates/fields/field-number-html.php
Original file line number Diff line number Diff line change
@@ -22,13 +22,21 @@
if ( empty( $field_settings['number_format'] ) && 'currency' === $gravityview->field->field->numberFormat ) {
echo $display_value;
} else {
$value = gravityview_number_format( $value, $decimals, ! empty( $field_settings['number_format'] ) );
if(!$field_settings['number_format']){
echo $value;
}else{
echo $field->get_value_entry_list( $value, $gravityview->entry, $gravityview->field->id, [], $form );
if($decimals){
global $wp_locale;
if($gravityview->field->field->numberFormat === 'decimal_comma'){
$wp_locale->number_format['decimal_point'] = ',';
$wp_locale->number_format['thousands_sep'] = '.';
}else{
$wp_locale->number_format['decimal_point'] = '.';
$wp_locale->number_format['thousands_sep'] = ',';
}

$value = gravityview_number_format( $value, $decimals, ! empty( $field_settings['number_format'] ) );
}

echo $field->get_value_entry_list( $value, $gravityview->entry, $gravityview->field->id, [], $form );

}
} else {
echo $display_value;