Fix Grid CSS regression (#2194) #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafaehlers This is a fix for the frontend on maps (and other custom templates that use the GV grid classes). For Maps there is the other PR that will fix the backend too, and updates its styles to the new layout classes. So this PR fill fix any version of Maps on the frontend. And the other PR (on Maps) will fix both the frontend ánd the backend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #2194.
When changing over to the new Grid styles, some CSS was moved over from the
gv-gridtogv-grid-row. For templates that are not (yet) updated, this will cause discrepancies.This will only fix the frontend for custom templates. The backend can only be fixed on the templates themselves.
💾 Build file (b93399e).