Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pollution fixes #1417

Merged
merged 39 commits into from
Jun 19, 2024
Merged

pollution fixes #1417

merged 39 commits into from
Jun 19, 2024

Conversation

screret
Copy link
Member

@screret screret commented Jun 14, 2024

What

removes the client lag caused by pollution by reducing particle count and instead making larger particles.
also makes singleblock generators output very low amounts of pollution and makes the strength be stored as a float so smaller amounts can be output at a time.

Implementation Details

new particle type that's like the basalt delta particle but colorable

Outcome

less laggy environmental hazards

@screret screret requested a review from a team as a code owner June 14, 2024 13:36
@300f20t
Copy link

300f20t commented Jun 14, 2024

It would be nice if this fix increased the maximum pollution limit, as it is too small.
2024-06-14_14 04 43

@screret
Copy link
Member Author

screret commented Jun 14, 2024

It would be nice if this fix increased the maximum pollution limit, as it is too small.

what?

@300f20t
Copy link

300f20t commented Jun 14, 2024

The pollution is too large and when transferring from the old version of GTm it becomes maximum and because of this it becomes impossible to play after 2-3 minutes of being on the base. Maybe I should have opened the issue.

@screret
Copy link
Member Author

screret commented Jun 14, 2024

that's... what this fixes.

@300f20t
Copy link

300f20t commented Jun 14, 2024

The fact that the maximum pm is 1000 is a pretty bad decision. In GT5, this value was several million.

@screret
Copy link
Member Author

screret commented Jun 14, 2024

it's not a maximum, it's the value at which it'll start spreading to chunks around it.

@screret
Copy link
Member Author

screret commented Jun 14, 2024

also this is not that close to GT5 pollution and smaller amounts are much more deadly

@300f20t
Copy link

300f20t commented Jun 14, 2024

It behaves very strangely and does not rise above 1000, but does not spread to other chunks.

@screret
Copy link
Member Author

screret commented Jun 14, 2024

have you tried the attached development build?
build output.zip

@300f20t
Copy link

300f20t commented Jun 14, 2024

I didn't want to create a issue because I couldn't reproduce the bug.

@300f20t
Copy link

300f20t commented Jun 14, 2024

image

@300f20t
Copy link

300f20t commented Jun 14, 2024

I'm not sure, but it seems to have worked.

@300f20t
Copy link

300f20t commented Jun 14, 2024

I couldn't find any information about the pollution other than your commits on Github. Does the modification include any means of removing pollution?

@screret
Copy link
Member Author

screret commented Jun 14, 2024

that already exists, it's called the Air Scrubber.

@screret screret linked an issue Jun 16, 2024 that may be closed by this pull request
2 tasks
@screret screret requested a review from mikerooni June 19, 2024 07:43
@screret screret merged commit cb7d336 into 1.20.1 Jun 19, 2024
2 checks passed
@screret screret deleted the sc/pollution-fixes branch June 19, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GTM + Xaero's Maps = logspam
3 participants