Overload AbstractRecipeLogic functions #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brachy84
approved these changes
Dec 18, 2023
| recipe = Recipe.trimRecipeOutputs(recipe, getRecipeMap(), metaTileEntity.getItemOutputLimit(), | ||
| metaTileEntity.getFluidOutputLimit()); | ||
|
|
||
| // Pass in the trimmed recipe to the parallel logic |
There was a problem hiding this comment.
Why remove this comment? It is still accurate
ALongStringOfNumbers
approved these changes
Jan 14, 2024
serenibyss
pushed a commit
that referenced
this pull request
Jan 21, 2024
Co-authored-by: alongstringofnumbers <[email protected]>
serenibyss
pushed a commit
that referenced
this pull request
Jan 21, 2024
Co-authored-by: alongstringofnumbers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds helper functions to AbstractRecipeLogic that allows the upcoming kitchen multiblock in GTFO to use external inventories to run recipes.
Implementation Details
Hopefully, the overrides don't mess with any tile entities, although there are no overloads that seem to be used anywhere that GTFO intends to use these new methods.
Outcome
Added more expansive signatures to AbstractRecipeLogic methods.
Potential Compatibility Issues
All of the original signatures were kept, so there probably won't be problems here.