fix gt tile entities not rendering in AE2 pattern outputs #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serenibyss
approved these changes
Jan 20, 2024
serenibyss
added
type: bug
serenibyss
pushed a commit
that referenced
this pull request
Jan 21, 2024
serenibyss
pushed a commit
that referenced
this pull request
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes GT Tile Entities not rendering in AE2 pattern outputs. This includes machines and pipelike tiles.
Also rewrites the existing compat for RS to use MethodHandles instead of reflection, which should hopefully improve performance. RS hard-blocks GT machines and pipes from rendering as pattern outputs as of version 1.6.15 and later, so this will have to be asm transformed or mixined in the future to restore this functionality to the latest RS versions.
Outcome
Prevents GT machines and pipes from rendering as invisible for AE2 pattern outputs.