Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing atlas initialization and update dependencies #15

Merged
merged 8 commits into from
Dec 20, 2023
Merged

Fix missing atlas initialization and update dependencies #15

merged 8 commits into from
Dec 20, 2023

Conversation

tehrengruber
Copy link
Contributor

@tehrengruber tehrengruber commented Dec 9, 2023 •
edited
Loading

Based on some of the changes by @wdeconinck here.

egparedes
egparedes reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I have a couple of suggestions to avoid problems in corner cases, but otherwise is ready to be merged.

.github/workflows/tox.yml Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
wdeconinck
wdeconinck approved these changes Dec 15, 2023
View reviewed changes
Copy link

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I like your atexit trick!

@wdeconinck
Copy link

By the way, I realise I still need to create a PR with my extended bindings. This is my first objective after New Year.

egparedes
egparedes approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ILGTM, thanks!

@tehrengruber tehrengruber merged commit 77a80d1 into master Dec 20, 2023
4 checks passed
@havogt havogt deleted the fix_initialization branch July 2, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdeconinck wdeconinck wdeconinck approved these changes

@egparedes egparedes egparedes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tehrengruber @wdeconinck @egparedes