refactor[next]: Change foast lowering from iterator of tuple to tuple of iterator #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehrengruber
commented
Feb 13, 2024
| @@ -130,7 +130,7 @@ def compilation_hash(otf_closure: stages.ProgramCall) -> int: | |||
| ) | |||
|
|
|||
| GTFN_DEFAULT_COMPILE_STEP: step_types.CompilationStep = compiler.Compiler( | |||
| cache_strategy=cache.Strategy.SESSION, builder_factory=compiledb.CompiledbFactory() | |||
| cache_strategy=cache.Strategy.PERSISTENT, builder_factory=cmake.CMakeFactory() | |||
There was a problem hiding this comment.
Will be removed before merge. Breaks code-quality so won't be forgotten.
havogt
requested changes
Feb 14, 2024
|
Let's quickly talk about testing tomorrow. |
havogt
approved these changes
Feb 15, 2024
tehrengruber
added a commit
that referenced
this pull request
Feb 28, 2024
#1449 introduced a hashing function for expressions that relied on Python's builtin `hash`. As `hash` is not stable across interpreter runs this broke caching in some cases. This PR fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes lowering from FOAST to ITIR to use tuples of iterators instead of iterators of tuples.
↑(λ(it) → it[0])(↑(λ() → {1, 2})is now({↑(λ() → 1)(), ↑(λ() → 2)()})[0]