Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update CI config to use new template for container build #1450

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Feb 8, 2024

The CSCS CI config was updated to use the new template for container build (.container-builder is deprecated).

@edopao edopao marked this pull request as ready for review February 8, 2024 15:29
Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks weird to me, why would I care about zen2 in my image? Do you know what's behind that? arm support?

@edopao
Copy link
Contributor Author

edopao commented Feb 8, 2024

@havogt
Copy link
Contributor

havogt commented Feb 8, 2024

but then why zen2 and not x86? who provides this image?

@havogt
Copy link
Contributor

havogt commented Feb 8, 2024

Ok, maybe you want to optimize for the specific architecture...

@edopao
Copy link
Contributor Author

edopao commented Feb 8, 2024

The name .container-builder-cscs-zen2 does not refer to a base Docker image. It refers to a base Gitlab job configuration, that selects the correct build cluster.

@edopao edopao merged commit 374f043 into GridTools:main Feb 8, 2024
31 checks passed
@edopao edopao deleted the ci-update branch February 8, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants