style: replace black+isort+flake8 tooling with ruff #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egparedes
changed the title
egparedes
changed the title
egparedes
requested changes
Feb 26, 2024
nfarabullini
commented
Feb 28, 2024
src/gt4py/next/program_processors/runners/dace_iterator/__init__.py
Outdated
Show resolved
Hide resolved
…tion (breaks QA checks).
…er migrating to ruff
nfarabullini
force-pushed
the
ruff_impl
branch
from
f00a5b2 to
acb1fef
Compare
egparedes
approved these changes
Feb 28, 2024
3 tasks
egparedes
pushed a commit
that referenced
this pull request
Sep 3, 2024
In PR #1466, `flake8`, `black`, and `isort` were replaced with the [ruff](https://astral.sh/ruff) linter and formatter. It seems there are a few leftovers of this transition. In this PR, I did a quick search for flake8 and deleted / replaced all instances found. Removing `flake8` means rebuilding the requirements (to propagate the changes to the frozen `requirements-*` files), which updates a couple of dependencies. We also decided to remove the `linter-*` tasks of `tox` since they have been replaced by `pre-commit`.
romanc
pushed a commit
to romanc/gt4py
that referenced
this pull request
Sep 6, 2024
isort has been replaced by ruff with PR GridTools#1466. Removing isort means rebuilding the requirements, which updates a couple of unrelated (to the isort removal) dependencies.
3 tasks
egparedes
pushed a commit
that referenced
this pull request
Sep 11, 2024
`isort` has been replaced by `ruff` in PR #1466. _Note_ Removing `isort` means rebuilding the requirements, which updates a couple of unrelated (to the `isort` removal) dependencies. _Note 2_ I also checked for `black` (formatter) and there are lingering references too. However, `black` is actively used as formatter in code generation https://github.com/GridTools/gt4py/blob/70dd7c34036e48c37f5047bf32573916836a4a35/src/gt4py/eve/codegen.py#L106 Co-authored-by: Roman Cattaneo <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code style and format changes moving from black+isort+flake8 to ruff.