feat[next]: Output argument with non-zero domain start #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not start at zero
tehrengruber
commented
Dec 11, 2024
| cases.verify(cartesian_case, copy_program, inp, out=out, ref=ref) | ||
|
|
||
|
|
||
| def test_in_field_arg_with_non_zero_domain_start(cartesian_case, copy_program_def): |
There was a problem hiding this comment.
This already worked before, I've just added a test.
tehrengruber
changed the title
…zero_domain_start' into field_arg_with_non_zero_domain_start
egparedes
reviewed
Jan 10, 2025
src/gt4py/next/program_processors/runners/dace_common/utility.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_python_codegen.py
Show resolved
Hide resolved
tests/next_tests/integration_tests/feature_tests/ffront_tests/test_execution.py
Outdated
Show resolved
Hide resolved
tests/next_tests/integration_tests/feature_tests/ffront_tests/test_program.py
Outdated
Show resolved
Hide resolved
…zero_domain_start' into field_arg_with_non_zero_domain_start
havogt
previously requested changes
Jan 16, 2025
edopao
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also adds a test for non-zero domain start input arguments, which already worked before.