Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing alert to toast message #195

Closed
wants to merge 5 commits into from

Conversation

MaximilianoCabreraP
Copy link

@MaximilianoCabreraP MaximilianoCabreraP commented Oct 15, 2024

Description

I add toast.css file to style it.
I change all the alerts to the new "showToast" function that receives a message and a type (danger, warning and success)
At the bottom, I add the new features with manage the toasted message

Fixes #194

Type of change

Please delete options that are not relevant.

[ x ] New feature (non-breaking change)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so that they can be reproduced.

  • Test A
  • Test B

Checklist:

  • [ x ] My code follows the style guidelines of this project
  • [ x ] I have performed a self-review of my code
  • [ x ] I have commented my code, particularly in hard-to-understand areas
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] My changes generate no new warnings
  • [ x ] Any dependent changes have been merged and published in downstream modules

@Anshgrover23
Copy link
Collaborator

@MaximilianoCabreraP kindly resolve conflicts.

Signed-off-by: Maximiliano Cabrera <[email protected]>
@MaximilianoCabreraP
Copy link
Author

ok, i fix this =)

@MaximilianoCabreraP
Copy link
Author

hi, could you approve this PR? :D

@Anshgrover23
Copy link
Collaborator

e@MaximilianoCabreraP kindly add before and after screenshots of your changes.

@Anshgrover23
Copy link
Collaborator

@MaximilianoCabreraP what is this??
image

@Anshgrover23
Copy link
Collaborator

@MaximilianoCabreraP we do not want this? your PR is not ready i am sending to draft ask me when it will be ready.
image

@Anshgrover23 Anshgrover23 marked this pull request as draft October 29, 2024 18:39
@MaximilianoCabreraP
Copy link
Author

Hi, sorry, it was ready 2 weeks ago. Some new approved PRs broke mine.
I'll fix it

@MaximilianoCabreraP MaximilianoCabreraP closed this by deleting the head repository Oct 29, 2024
@MaximilianoCabreraP
Copy link
Author

Sorry, I couldn't fix this since this PR, too many changes and conflicts.
I create a new Fork and I made a new PR here: #334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Change Alert to Toast
2 participants