Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added hover animation #312

Merged
merged 5 commits into from
Oct 26, 2024
Merged

Conversation

Shreyanshi210205
Copy link
Contributor

@Shreyanshi210205 Shreyanshi210205 commented Oct 24, 2024

Description

Added hover animation to the cards in the "Why we need this" section

Fixes #308

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change)

How Has This Been Tested?

When go to "Why we need this" section we can see the cards showing hover animation

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Anshgrover23
Copy link
Collaborator

@Shreyanshi210205 your one check is failing, run npm run format
and kindly share before and after screenshots for referencing in the PR.

@Shreyanshi210205
Copy link
Contributor Author

image
@Anshgrover23 fixed the check failing. Kindly check once.

Copy link
Collaborator

@Anshgrover23 Anshgrover23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE WORK!

@Anshgrover23 Anshgrover23 merged commit bf7677a into Groverio:main Oct 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Adding hover animation to the importance page cards.
2 participants