ci: Drop gemfile.locks and stabilize the CI (preparation for graphql-2.3.) compatibility #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a bad practice to commit Gemfile.lock files into gem repositories - `gemspec` files should be the source of truth for dependencies. I removed all Gemfile.lock files and updated the CircleCI configuration to use the Gemfile for cache keys. Additionally, I updated the `rack` development dependency in the gemspec and locked it to version 2.0 because of the breaking changes in version 3.
Bajena
changed the title
Bajena
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we're working on making this gem support
graphql-ruby2.3. (our fork already supports and the version is live on production.In order to prepare for the 2.3. compatibility changes we had to stabilize the CI a little:
Gemfile.lockfiles into gem repositories -gemspecfiles should be the source of truth for dependencies. I removed all Gemfile.lock files and updated the CircleCI configuration to use the Gemfile for cache keys..ruby-versionused in development to 3.2.0. I think it should be fine as 2.7.5 is quite old alreadygraphl-2.0appraisal to2.0.19as newer patch versions were not backwards compatible which started crashing CI. I'll upgrade it in the next PR