Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: graphql-ruby 2.3 compatibility #282

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

Bajena
Copy link

@Bajena Bajena commented Sep 10, 2024

requires merging #276 first

fixes #276

This PR:

  • Adds a new appraisal for graphql-ruby 2.3
  • Adjusts the Tracer method to support the new way of module-based tracing (https://graphql-ruby.org/queries/tracing)
  • Adjusts integration tests to use trace_with method in federated services
  • Changes documentation to inform about the new way of tracing
  • Adjusts schema generator to work with newer graphql-ruby versions (>2.3.8). It was breaking due to the lack of warden method.

@Bajena Bajena changed the title graphql-ruby 2.3 compatibility fix: graphql-ruby 2.3 compatibility Sep 10, 2024
@such
Copy link
Contributor

such commented Oct 14, 2024

When can we expect this to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphql 2.3.8 removes "warden", breaking schema composition etc
2 participants