Bounds and Animation Property Deduplication #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every time we need to make a place to store a region's bounds, we have to write quite a bit of boilerplate code to stash the bounds type into the collision modifier. This removes the need to do that by making a helper function that generates those helper functions for us. Generally, we would use `functools.partial` to do this, but Blender requires function objects for the `EnumProperty`'s getter and setter. Partial objects raise a `TypeError`.
Hoikas
force-pushed
the
bounds_storage_overhaul
branch
from
8401c66
to
e74e614
Compare
This migrates duplicated bounds properties (i.e. those *NOT* found on the collision modifier) to be stored on the collision modifier. This can potentially be a lossy process if there are multiple conflicting bounds property values for a single object. This may result in some Ages having "new" bugs appear, but, really, they were only working by sheer dumb luck before. It's better this way.
Hoikas
force-pushed
the
bounds_storage_overhaul
branch
from
e74e614
to
adb8b23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of changes to de-duplicate code and storage of bounds and animation related properties. All bounds properties are now proxies to the collision modifier's bounds property with an automated upgrade path. All of the manual getters and setters in code that was already doing this have been removed and replaced with a helper to register bounds properties. Animation properties, especially material/texture animations, have been greatly simplified by removing verbose boilerplate around property registration.