Skip to content

Commit

Permalink
update sampling fractions and other tweaks (#172)
Browse files Browse the repository at this point in the history 
* update sampling fractions, drop endcap collections from output, and add switch to save shower shape vars and run photon ID tool

* add comment about outdated up/downstream corrections
  • Loading branch information
@giovannimarchiori
giovannimarchiori authored Jul 4, 2024
1 parent 5f2c548 commit 3c82636
Showing 1 changed file with 76 additions and 16 deletions.
92 changes: 76 additions & 16 deletions FCCee/FullSim/ALLEGRO/ALLEGRO_o1_v03/run_digi_reco.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
from Configurables import AugmentClustersFCCee
# MVA calibration
from Configurables import CalibrateCaloClusters
# photon/pi0 identification
from Configurables import PhotonIDTool
# Logger
from Gaudi.Configuration import INFO, VERBOSE, DEBUG
# units and physical constants
Expand All @@ -60,17 +62,18 @@
#
# for big productions, save significant space removing hits and cells
# however, hits and cluster cells might be wanted for small productions for detailed event displays
# also, cluster cells are needed for the MVA training
# cluster cells are not needed for the training of the MVA energy regression nor the photon ID since needed quantities are stored in cluster shapeParameters
# saveHits = False
# saveCells = False
# saveClusterCells = False
saveHits = True
saveCells = True
saveClusterCells = True

# ECAL barrel parameters for digitisation
samplingFraction=[0.37586625991994105] * 1 + [0.13459486704309379] * 1 + [0.142660085165352] * 1 + [0.14768106642302886] * 1 + [0.15205230356024715] * 1 + [0.15593671843591686] * 1 + [0.15969313426201745] * 1 + [0.16334257010426537] * 1 + [0.16546584993953908] * 1 + [0.16930439771304764] * 1 + [0.1725913708958098] * 1
upstreamParameters = [[0.025582045561310333, -0.9524128168665387, -53.10089405478649, 1.283851527438571, -295.30650178662637, -284.8945817377308]]
downstreamParameters = [[0.0018280333929494054, 0.004932212590963076, 0.8409676097173655, -1.2676690014715288, 0.005347798049886769, 4.161741293789687]]
samplingFraction=[0.3800493723322256] * 1 + [0.13494147915064658] * 1 + [0.142866851721152] * 1 + [0.14839315921940666] * 1 + [0.15298362570665006] * 1 + [0.15709704561942747] * 1 + [0.16063717490147533] * 1 + [0.1641723795419055] * 1 + [0.16845490287689746] * 1 + [0.17111520115997653] * 1 + [0.1730605163148862] * 1
upstreamParameters = [[0.025582045561310333, -0.9524128168665387, -53.10089405478649, 1.283851527438571, -295.30650178662637, -284.8945817377308]] # FIXME: to be updated for ddsim
downstreamParameters = [[0.0018280333929494054, 0.004932212590963076, 0.8409676097173655, -1.2676690014715288, 0.005347798049886769, 4.161741293789687]] # FIXME: to be updated for ddsim

ecalBarrelLayers = len(samplingFraction)
resegmentECalBarrel = False
Expand All @@ -87,21 +90,24 @@

# BDT regression from total cluster energy and fraction of energy in each layer (after correction for sampling fraction)
# not to be applied (yet) for ECAL+HCAL clustering (MVA trained only on ECAL so far)
applyMVAClusterEnergyCalibration = True and not runHCal #
applyMVAClusterEnergyCalibration = True and not runHCal

# calculate cluster energy and barycenter per layer and save it as extra parameters
addShapeParameters = True and not runHCal
ecalBarrelThetaWeights = [-1, 3.0, 3.0, 3.0, 4.25, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0] # to be recalculated for V03, separately for topo and calo clusters...

# run photon ID algorithm
runPhotonIDTool = False

#
# ALGORITHMS AND SERVICES SETUP
#

# Input: load the output of the SIM step
evtsvc = k4DataSvc('EventDataSvc')
evtsvc.input = inputfile
podioevent = k4DataSvc('EventDataSvc')
podioevent.input = inputfile
input_reader = PodioInput('InputReader')
podioevent = k4DataSvc("EventDataSvc")


# Detector geometry
# prefix all xmls with path_to_detector
Expand Down Expand Up @@ -145,15 +151,15 @@
layerFieldName="layer")
# * ECAL endcap
calibEcalEndcap = CalibrateCaloHitsTool(
"CalibrateECalEndcap", invSamplingFraction="4.27") # FIXME: to be updated for ddsim
"CalibrateECalEndcap", invSamplingFraction="4.27") # FIXME: to be updated for ddsim

if runHCal:
# HCAL barrel
calibHcells = CalibrateCaloHitsTool(
"CalibrateHCal", invSamplingFraction="29.4202")
# HCAL endcap
calibHcalEndcap = CalibrateCaloHitsTool(
"CalibrateHCalEndcap", invSamplingFraction="29.4202") # FIXME: to be updated for ddsim
"CalibrateHCalEndcap", invSamplingFraction="29.4202") # FIXME: to be updated for ddsim

# Create cells in ECal barrel (needed if one wants to apply cell calibration,
# which is not performed by ddsim)
Expand Down Expand Up @@ -412,6 +418,7 @@
readoutNames=[ecalBarrelReadoutName],
layerFieldNames=["layer"],
thetaRecalcWeights=[ecalBarrelThetaWeights],
do_photon_shapeVar=runPhotonIDTool,
OutputLevel=INFO
)

Expand All @@ -436,6 +443,25 @@
OutputLevel=INFO
)

if runPhotonIDTool:
if not addShapeParameters:
print("Photon ID tool cannot be run if shower shape parameters are not calculated")
runPhotonIDTool = False
else:
inClusters = ""
if applyMVAClusterEnergyCalibration:
inClusters = calibrateCaloClusters.outClusters.Path
else:
inClusters = augmentCaloClusters.outClusters.Path

photonIDCaloClusters = PhotonIDTool("photonIDCaloClusters",
inClusters=inClusters,
outClusters="PhotonID" + inClusters,
mvaModelFile="data/bdt-photonid-weights-CaloClusters.onnx",
mvaInputsFile="data/bdt-photonid-inputs-CaloClusters.json",
OutputLevel=INFO
)

if doTopoClustering:
# Produce topoclusters (ECAL only or ECAL+HCAL)
createTopoInput = CaloTopoClusterInputTool("CreateTopoInput",
Expand Down Expand Up @@ -528,14 +554,16 @@
readoutNames=[ecalBarrelReadoutName],
layerFieldNames=["layer"],
thetaRecalcWeights=[ecalBarrelThetaWeights],
do_photon_shapeVar=runPhotonIDTool,
OutputLevel=INFO)

if applyMVAClusterEnergyCalibration:
inClusters = ""
if addShapeParameters:
inClusters = "Augmented" + createTopoClusters.clusters.Path
else:
inClusters = createTopoClusters.clusters.Path,
inClusters = createTopoClusters.clusters.Path

calibrateCaloTopoClusters = CalibrateCaloClusters("calibrateCaloTopoClusters",
inClusters=inClusters,
outClusters="Calibrated" + createTopoClusters.clusters.Path,
Expand All @@ -550,17 +578,35 @@
OutputLevel=INFO
)

if runPhotonIDTool:
if not addShapeParameters:
print("Photon ID tool cannot be run if shower shape parameters are not calculated")
runPhotonIDTool = False
else:
inClusters = ""
if applyMVAClusterEnergyCalibration:
inClusters = calibrateCaloTopoClusters.outClusters.Path
else:
inClusters = augmentCaloTopoClusters.outClusters.Path

photonIDCaloClusters = PhotonIDTool("photonIDCaloTopoClusters",
inClusters=inClusters,
outClusters="PhotonID" + inClusters,
mvaModelFile="data/bdt-photonid-weights-CaloTopoClusters.onnx",
mvaInputsFile="data/bdt-photonid-inputs-CaloTopoClusters.json",
OutputLevel=INFO
)

# Output
out = PodioOutput("out",
OutputLevel=INFO)
out.filename = "ALLEGRO_sim_digi_reco.root"

# drop the unpositioned ECal barrel cells
# drop the unpositioned ECal and HCal barrel and endcap cells
if runHCal:
out.outputCommands = ["keep *", "drop emptyCaloCells", "drop ECalBarrelCells*", "drop HCalBarrelCells*"]
out.outputCommands = ["keep *", "drop emptyCaloCells", "drop ECalBarrelCells*", "drop HCalBarrelCells*", "drop %s" % createEcalEndcapCells.cells.Path]
else:
out.outputCommands = ["keep *", "drop HCal*", "drop emptyCaloCells", "drop ECalBarrelCells*"]
out.outputCommands = ["keep *", "drop HCal*", "drop emptyCaloCells", "drop ECalBarrelCells*", "drop %s" % createEcalEndcapCells.cells.Path]
out.outputCommands.append("drop %s" % ecalBarrelReadoutName)
out.outputCommands.append("drop %s" % ecalBarrelReadoutName2)
if runHCal:
Expand All @@ -580,9 +626,12 @@
if not saveHits:
out.outputCommands.append("drop %s_contributions" % ecalBarrelReadoutName)
out.outputCommands.append("drop %s_contributions" % ecalBarrelReadoutName2)
out.outputCommands.append("drop %s_contributions" % ecalEndcapReadoutName)
if not saveCells:
out.outputCommands.append("drop %s" % ecalBarrelPositionedCellsName)
out.outputCommands.append("drop %s" % ecalBarrelPositionedCellsName2)
out.outputCommands.append("drop %s" % ecalEndcapReadoutName)
if resegmentECalBarrel:
out.outputCommands.append("drop %s" % ecalBarrelPositionedCellsName2)
if runHCal:
out.outputCommands.append("drop %s" % hcalBarrelPositionedCellsName2)
if resegmentECalBarrel:
Expand All @@ -591,6 +640,10 @@
if not saveClusterCells:
out.outputCommands.append("drop Calo*ClusterCells*")

# if we decorate the clusters, we can drop the non-decorated ones
if addShapeParameters:
out.outputCommands.append("drop %s" % augmentCaloClusters.inClusters)

# CPU information
chra = ChronoAuditor()
audsvc = AuditorSvc()
Expand Down Expand Up @@ -663,6 +716,10 @@
TopAlg += [calibrateCaloClusters]
calibrateCaloClusters.AuditExecute = True

if runPhotonIDTool:
TopAlg += [photonIDCaloClusters]
photonIDCaloClusters.AuditExecute = True

if doTopoClustering:
TopAlg += [createTopoClusters]
createTopoClusters.AuditExecute = True
Expand All @@ -679,6 +736,10 @@
TopAlg += [calibrateCaloTopoClusters]
calibrateCaloTopoClusters.AuditExecute = True

if runPhotonIDTool:
TopAlg += [photonIDCaloTopoClusters]
photonIDCaloTopoClusters.AuditExecute = True

TopAlg += [
out
]
Expand All @@ -690,4 +751,3 @@
ExtSvc=ExtSvc,
StopOnSignal=True,
)

0 comments on commit 3c82636

Please sign in to comment.