Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen tracks for allegro #207

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

BrieucF
Copy link
Contributor

@BrieucF BrieucF commented Sep 24, 2024

  • Migration to IOSvc in order to have Gaudi functionals properly outputting collections
  • Avoid calling AuditExecute everytime one adds an algorithm
  • Add Tracks from gen particle

@giovannimarchiori
Copy link
Contributor

Nice! I guess it's not easy / worth spending time to avoid hardcoding Bz in the tracking module and taking it instead from the k4geo xml?

@BrieucF
Copy link
Contributor Author

BrieucF commented Sep 24, 2024

Nice! I guess it's not easy / worth spending time to avoid hardcoding Bz in the tracking module and taking it instead from the k4geo xml?

This is on the to do list for the TracksFromGenParticles algorithm ;-)

@BrieucF
Copy link
Contributor Author

BrieucF commented Sep 24, 2024

Normally the test should pass tomorrow morning, let's see

@giovannimarchiori
Copy link
Contributor

Retrying the tests

@BrieucF
Copy link
Contributor Author

BrieucF commented Sep 25, 2024

Tests are fixed :-)

@giovannimarchiori
Copy link
Contributor

ok, let's merge this PR then!

@giovannimarchiori giovannimarchiori merged commit 129ab36 into HEP-FCC:main Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants