various updates to ALLEGRO digi-reco script

[giovannimarchiori]

In the README, move part about copying calibration files before running ddsim, so that file ALLEGRO_sim.root is not overridden by the one in the calibration area, which is outdated (we should update it but I had no permission to delete the old one)

In run_digi_reco.py:

• enable new eventcounter
• make various options configurable from the command line to avoid having to manually edit the script when rerunning with different options
• add options for including xtalk
• fix output configuration

[BrieucF]

Hi Giovanni,

I propose to keep the README as it is, because people who just want the SIM step do not need to download those files. Shall we simply rename the file ALLEGRO_sim.root from the fccsw-web eos to something like ALLEGRO_sim_central.root (and propagate to https://github.com/HEP-FCC/k4RecCalorimeter/blob/main/RecCalorimeter/tests/options/runEcalBarrel_ReconstructionTopoClusters_crosstalk.py)?

[giovannimarchiori]

Hi Brieuc,
I am not sure… downloading the root file took longer for me than regenerating it with ddsim. And when I ran on the central file I found out that it was old because k4run would crash on it. Can we at least put the root file in a subdirectory so that it’s not copied by default with the cp or scp * command? And update the root file?

[BrieucF]

I have reproduced the file with the latest nightlies, moved it to /eos/project/f/fccsw-web/www/filesForSimDigiReco/ALLEGRO/ALLEGRO_o1_v03/forTests/pythia_ee_z_qq_10evt_ALLEGRO_sim.root and updated the test relying on it from k4RecCalorimeter (HEP-FCC/k4RecCalorimeter#130)

[giovannimarchiori]

OK I updated the README to mention the new file

[giovannimarchiori]

Hi @BrieucF
FYI - the test that fails is not related to these changes, it's the IDEA test:

gmarchio@apcatlas01:~/work/fcc/allegro/fullsim/FCC-config/build % ctest
Test project /home/gmarchio/work/fcc/allegro/fullsim/FCC-config/build
    Start 1: ALLEGRO_o1_v03
1/2 Test #1: ALLEGRO_o1_v03 ...................   Passed  107.80 sec
    Start 2: IDEA_o1_v03
2/2 Test #2: IDEA_o1_v03 ......................***Failed   36.00 sec

We need to fix to take into account the recent changes mentioned here (HEP-FCC/k4RecCalorimeter#124

digitizer       ERROR ServiceLocatorHelper::service: can not locate service RndmGenSvc
VTXBdigitizer       ERROR Couldn't get RndmGenSvc!
EventLoopMgr        ERROR Unable to initialize Algorithm: VTXBdigitizer
ServiceManager      ERROR Unable to initialize Service: EventLoopMgr
ApplicationMgr      ERROR Application Manager Terminated with error code 1

[giovannimarchiori]

Hi @BrieucF are you happy with the updated README, the updated script and the fix to the IDEA test?

[giovannimarchiori]

Hi @BrieucF
I rebased, and since the only changed you asked (restore the README) was done in the previous commit, I am going to merge the PR ;)