Protection in all_invariant_masses computation #342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
FCCAnalyses
experts - when I implementedall_invariant_masses
a while ago, I forgot to include a protection on the numbers of jets. This is problematic when running on events that do not have at least 2 jets - which can happen for example with the WW background even if you require exclusive clustering with njets = 4. See attached the error, stage 1 config file, and command run to produce the error:error.log
cmd.log
ZH_Hadronic_stage1.py.txt
The error is fixed for me when adding the simple protection.
Files edited:
analyzers/dataframe/src/JetConstituentsUtils.cc
:By the way, I've encountered the same problem when importing this weaver example as by default it computes invariant mass assuming you have two jets. Given that this is just an example, not sure if the protection is necessary here.