fix photon ID inputs when noise is on #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrieucF
reviewed
Oct 24, 2024
| // Negative values can happen when noise is on and not filtered | ||
| // Negative values very close to zero can happen due to numerical precision | ||
| if (w_theta2 < 0.) { | ||
| warning() << "w_theta2 in theta width calculation is negative: " << w_theta2 << " , will set theta width to zero (this might happen when noise simulation is on)" << endmsg; |
There was a problem hiding this comment.
If this happens frequently when noise is ON, shall we have this print only for verbose?
There was a problem hiding this comment.
There are cases when the computation is negative when noise is OFF just due to numerical precision, and also for the noise case I think for the user it might be useful to get a least few warnings to make them aware. I have committed a version of the code in which the maximum number of warning statements over the whole execution is configurable and is by default set to 10
|
LGTM! @kjvbrt ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating RMS width of showers in layers of ECAL when noise is on the RMS can be negative due to negative-energy cells. In that case the code was crashing. This PR will set the width to zero for those cases