Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove CellPositionsHCalBarrelPhiThetaSegTool #127

Merged

Conversation

giovannimarchiori
Copy link
Contributor

BEGINRELEASENOTES

@giovannimarchiori
Copy link
Contributor Author

Remaining places using the old tool:

BrieucF/LAr_scripts · FCCSW_ecal/run_thetamodulemerged.py
=> easy to fix, but discontinued - not worth it?

HEP-FCC/fcc-tutorials · full-detector-simulations/FCCeeGeneralOverview/run_ALLEGRO_RECO.py
=> the tutorial script is anyway out of sync with the latest version of run_ALLEGRO_RECO.py (which I plan to update soon) so we'd rather update the tutorial when it's time for another round of tutorials

HEP-FCC/FCC-config · FCCee/FullSim/ALLEGRO/ALLEGRO_o1_v02/run_digi_reco.py
=> v02 is superseded by v03, but maybe we want to keep the possibility to run the reconstruction code for it? In that case I can fix this in a quick little PR

@giovannimarchiori
Copy link
Contributor Author

@BrieucF or @kjvbrt do you have ny feedback?
Thanks
Giovanni

@kjvbrt
Copy link
Contributor

kjvbrt commented Nov 8, 2024

Hi @giovannimarchiori, I'm fine with removal, just keep ALLEGRO_o1_v02 running :)

How about using the ALLEGRO script directly from FCC-config in the tutorial(s)?

@giovannimarchiori
Copy link
Contributor Author

Hi @kjvbrt
so this HEP-FCC/FCC-config#218 will make ALLEGRO_o1_v02 run with the change in this PR.
About the tutorial - I think we should update it to use the latest developments. Give me some time while we try to wrap up a few things and update the official ALLEGRO script in FCC-config, and then we could use that also in the tutorials.
Please let me know if this is enough for merging this PR and HEP-FCC/FCC-config#218
Cheers,
Giovanni

@kjvbrt
Copy link
Contributor

kjvbrt commented Nov 8, 2024

Ok, looks good to me :)

@kjvbrt kjvbrt merged commit 5646fd1 into HEP-FCC:main Nov 8, 2024
4 checks passed
@giovannimarchiori giovannimarchiori deleted the gmarchio-main-20241106-removeoldtool branch November 13, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CellPositionsHCalBarrelPhiThetaSegTool vs CellPositionsHCalPhiThetaSegTool
2 participants