Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for ecal-hcal barrel linking in neighbour finder #129

Merged

Conversation

giovannimarchiori
Copy link
Contributor

Fixes a couple of issues pointed out by Archil Durglishvili when matching ecal-hcal
BEGINRELEASENOTES

  • bug in bin calculation (shifted by 0.5)
  • avoid looping both on ecal and hcal
    ENDRELEASENOTES
    Checked the impact of both changes: 1st one had tiny effect on cluster energy; 2nd has no impact as expected

@BrieucF
Copy link
Contributor

BrieucF commented Nov 12, 2024

@giovannimarchiori
Copy link
Contributor Author

Fixed

@BrieucF BrieucF merged commit 150585f into HEP-FCC:main Nov 12, 2024
4 checks passed
@giovannimarchiori giovannimarchiori deleted the gmarchio-main-20241108-neighboursfix branch November 13, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants