-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gaudi algorithm to perform MVA calibration of cluster energies #68
Add Gaudi algorithm to perform MVA calibration of cluster energies #68
Conversation
Hi @kjvbrt , |
This is really great to have! Thanks Giovanni! For the trained model, I propose to centralize them here |
Hi @BrieucF , wouldn't it be better to put the files in GitHub, so that we use its versioning system, record changes in the commit messages, can track more easily when files were updated, and so on? They are small files, they are not going to make the repository too big |
If they are small enough why not |
Those from LGBM, which has a performance very similar to XGB, are 300-400k. Those from XGB are about 2.5M |
On the other hand the diff of those files will always be a "full diffs" so not sure the gitHub versioning really brings something more than having our models as
|
But ok, we can decide later, this should not prevent us to merge this PR |
Implement a Gaudi algorithm that reads a model via ONNX runtime and calibrates the clusters
Pre-trained models for ALLEGRO's ECAL will be uploaded in the LAr_scripts package (and FCC-config)
In principle the code could also run a calibration for ECAL+HCAL clusters, if it is trained for that purpose and makes sense.
I put this in RecFCCeeCalorimeter since I'm working on the ee machine but I think the code is general enough that could be promoted to RecCalorimeter.
Also, the code calculates in input the cluster energies per layers from the cells. Since this information is needed also by other algorithms, it would make sense as a next step to factorise this part into a separate algorithms that decorates the clusters in memory with some additional variables (energy fractions, shower shapes, ..) that are available to all subsequent algorithms.
Tagging @BrieucF