Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds method to read device data including timing information #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gucki
Copy link

@gucki gucki commented Nov 6, 2024

As I needed to mix multiple streams I needed the timing information. For backwards compatibility, this PR more or less simply duplicates the existing method and additionally returns the timing information.

@HEnquist
Copy link
Owner

HEnquist commented Nov 6, 2024

Thanks! I think this could just as well be added to the existing method instead of adding a second one. That's a breaking change, but a small one that is trivial to handle.
And when anyway making changes, why not return both the position values?

HRESULT GetBuffer(
  [out] BYTE   **ppData,
  [out] UINT32 *pNumFramesToRead,
  [out] DWORD  *pdwFlags,
  [out] UINT64 *pu64DevicePosition,
  [out] UINT64 *pu64QPCPosition
);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants