Add review page to navigator #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The review page is the last page of the navigator. It does not use the navigator form component like the other pages of the form. It Only shows nav state when the form as been submitted.
…ator Add review page to navigator
rahearn
approved these changes
Dec 14, 2020
| @@ -9,7 +9,7 @@ import { Form as UswdsForm, Button } from '@trussworks/react-uswds'; | |||
| import { useForm } from 'react-hook-form'; | |||
|
|
|||
| function Form({ | |||
| initialData, onSubmit, onDirty, saveForm, renderForm, | |||
There was a problem hiding this comment.
Love using onContinue here, very clear that we're not submitting the whole process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The review page is the last page of the navigator. It does not use the navigator form component like the other pages of the form. It only shows nav state when the form as been submitted.
Note
This PR adds the mechanism for adding a review page. The current review page is a placeholder. There will be an additional PR with the review page as designed later. The hope is splitting up the PRs a bit makes for an easier review. If you feel we need to wait until the designed page is in place feel free to close without merging!
How to test
Compare against the desgin of the side nav.
Issue(s)
Checklist